Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Update banner logo on main website#5653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tacaswell commentedDec 10, 2015
the gh preview of the svg is cropped, I hope that is just gh doing a bad job rendering? |
mdboom commentedDec 10, 2015
This is what the github preview looks like for me:
|
DOC: Update banner logo on main website
DOC: Update banner logo on main website
tacaswell commentedDec 15, 2015
backported to v1.5.0-doc as325e47b |
WeatherGod commentedDec 29, 2015
Viewing the devdocs using Firefox 43 on Ubuntu, the banner looks cropped and the radar chart logo is misplaced. |
jenshnielsen commentedDec 29, 2015
Confirming. It looks good in Firefox on OSX but broken in firefox on Ubuntu 15.10 (virtual machine) |
jenshnielsen commentedDec 29, 2015
This is rendering only the svg image |
WeatherGod commentedDec 29, 2015
yup, that is what it looks like to me. |
mdboom commentedDec 29, 2015
Sorry, guys. Amateur mistake. We should convert the text to paths, since we don't ship that font. (It looks fine for me, because I have the font installed). I'll have a PR shortly. |
cgohlke commentedJan 11, 2016
BTW, the SVG file breaks the Microsoft Compiled HTML Help (CHM) file. HTML Help control and SumatraPDF display a white placeholder of 540x617 px instead of the logo. xCHM does not render SVG either. |
mdboom commentedJan 12, 2016
We'll probably need to add a PNG fallback for that case. Since I don't have the tooling to validate a CHM, is this something you could do? |
This updates the banner logo on the
index.htmlof the website to the new logo we've been making stickers of for about a year.I know there are plans afoot to do more drastic things to the website, but this is an easy thing we can do now that looks a lot cleaner than what we currently have.