Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
No edges on filled things by default#5596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- for plot, the default marker edge is now the color of the marker - for scatter the marker edge color now follows the face colorclosesmatplotlib#4679
| @@ -1986,7 +1986,7 @@ def bar(self, left, height, width=0.8, bottom=None, **kwargs): | |||
| xerr = kwargs.pop('xerr', None) | |||
| yerr = kwargs.pop('yerr', None) | |||
| error_kw = kwargs.pop('error_kw', dict()) | |||
| ecolor = kwargs.pop('ecolor',None) | |||
| ecolor = kwargs.pop('ecolor','k') | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
shouldn't this pull fromcolor instead? That way, there is no visible edge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The 'e' here stands for 'errorbar' not 'edge'
👍 modulo Ben's concerns about the indentation. I tend to push the continued if lines in an extra 4 spaces. |
Updated addressing comments here. |
| @@ -325,7 +325,7 @@ def _makefill(self, x, y, kw, kwargs): | |||
| seg = mpatches.Polygon(np.hstack((x[:, np.newaxis], | |||
| y[:, np.newaxis])), | |||
| facecolor=facecolor, | |||
| fill=True, | |||
| fill=kwargs.get('fill',True), | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What prompted this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
histogram steps (for one) go through this path, but sometimes passfill=False. If that gets ignored, than the patch will have neither fill or stroke in the new scheme here.
👍 other than my confusion about a |
I think this is good to go. |
| @@ -497,3 +497,5 @@ animation.convert_path: convert # Path to ImageMagick's convert binary. | |||
| # is also the name of a system tool. | |||
| animation.convert_args: | |||
| animation.html: none | |||
| _internal.classic_mode: True | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
There is a "no newline at end of file" marker here. I've never seen that before. Doesn't PEP8 require a newline at end of file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, missed this comment as I was pressing merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
PEP8 doesn't apply as this isn't a Python file ;) But yes, we can go in and add the newline next time we touch this file.
STY: No edges on filled things by default
STY: No edges on filled things by default
back ported as27adae6 |
Part of the 2.0 style changes.