Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix errorbar extension arrows#5586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

mdboom
Copy link
Member

The arrows on errorbar extensions are currently "centered" at the tip of the arrow. This means that if the errorbar line width becomes larger it sticks out from underneath the arrow head, looking quite odd.

This adds new triangle markers that are centered at the base on the arrow head rather than the tip and uses those for errorbar extensions.

@mdboommdboom added this to thenext major release (2.0) milestoneNov 30, 2015
@jenshnielsen
Copy link
Member

pep8 :(

/home/travis/build/matplotlib/matplotlib/lib/matplotlib/lines.py:37:1: E302 expected 2 blank lines, found 1

@QuLogic
Copy link
Member

I assume these are unrelated, but the scatter markers don't seem quite so centred and one of the axes intest_axes/errorbar_mixed.png is in the wrong colour.

@mdboom
Copy link
MemberAuthor

The markers looking slightly off center is due to37927b2. It makes the markers look more round, but it also no longer centers them around 0. I'll see if there's a better middle ground in a separate PR.

Good point about the update of the color intest_axes/errorbar_mixed.png. The test is explicitly asking for green there -- I'll have to get to the bottom of why that isn't being obeyed.

@mdboommdboomforce-pushed theerrorbar-extension-arrows branch 2 times, most recently frome1dbeb8 to98a5944CompareDecember 1, 2015 13:50
@mdboom
Copy link
MemberAuthor

The test is explicitly asking for green there -- I'll have to get to the bottom of why that isn't being obeyed.

I think this was just due to a mistake on my part. It's been corrected here.

@tacaswell
Copy link
Member

Do we want to revert37927b2 ? It did fix a problem, but seems to have created another one which is just as bad.

@mdboom
Copy link
MemberAuthor

Do we want to revert37927b2 ? It did fix a problem, but seems to have created another one which is just as bad.

I'm wondering if it can be addressed by snapping only the end points and not the control points of the Bézier curve. I plan to experiment with that today when I get a chance. If that doesn't yield better results then, yes, maybe reverting is the best option.

EDIT: Actually -- it's already doing what I was planning to try. (git blame == me).

        if (m_snap && agg::is_vertex(code)) {            *x = floor(*x + 0.5) + m_snap_value;            *y = floor(*y + 0.5) + m_snap_value;        }

@mdboom
Copy link
MemberAuthor

See#5603 for a possible solution to the off-centered marker issue.

@mdboom
Copy link
MemberAuthor

Let's hold on this one until#5603 is merged.

@tacaswell
Copy link
Member

I kicked to restart on current master, but@mdboom needs to re-regenerate the images anyway.

@mdboommdboomforce-pushed theerrorbar-extension-arrows branch from98a5944 toa1c4bf7CompareDecember 6, 2015 14:22
@mdboom
Copy link
MemberAuthor

I've redone the baseline images here after#5603. Once Travis passes, I'd say this is good to go.

@jenshnielsen
Copy link
Member

The superscript changes in errorbar_mixed.png are not for the better but I assume they are unrelated?

@mdboom
Copy link
MemberAuthor

I think that might be fixed in master already. I'll rebase and see what happens locally.

@mdboom
Copy link
MemberAuthor

I think the new superscript placement is fine -- I realize it's not as high, but with respect to all of the other combinations that sub/super can find themselves in, I think it's the best choice for the DejaVu font -- anything else has negative consequences in other dimensions. See#4873.

@mdboommdboomforce-pushed theerrorbar-extension-arrows branch froma1c4bf7 toeceb41bCompareDecember 10, 2015 18:48
@mdboommdboomforce-pushed theerrorbar-extension-arrows branch fromeceb41b to2b34996CompareDecember 14, 2015 18:22
@mdboom
Copy link
MemberAuthor

Rebased to test this in zero-tolerance mode.

jenshnielsen added a commit that referenced this pull requestDec 15, 2015
@jenshnielsenjenshnielsen merged commit957cc90 intomatplotlib:masterDec 15, 2015
jenshnielsen added a commit that referenced this pull requestDec 15, 2015
@jenshnielsen
Copy link
Member

backported asebf81db

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestDec 19, 2015
@QuLogic
Copy link
Member

Backport to v2.x is actually via4f40a9d.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

4 participants
@mdboom@jenshnielsen@QuLogic@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp