Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fix #5281: Include ticks in tight bounding box#5502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -568,7 +568,7 @@ def get_window_extent(self, renderer): | |||
| ignore=True) | |||
| # correct for marker size, if any | |||
| if self._marker: | |||
| ms = (self._markersize / 72.0 * self.figure.dpi) * 0.5 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What is this change for? I assume the issue is that with out this out ticks still get chopped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes. The assumption that markers only fill (-0.5, 0.5) is only true for circles. Ticks fill (0, 1) or (-1, 0) depending on "in" or "out".
Also breaks every single tight_layout test |
Not surprised it breaks tight layout tests. Will probably need to tie this change to |
No description provided.