NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

ENH: pass dash_offset through to gc for Line2D#5433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mdboom merged 4 commits intomatplotlib:masterfromtacaswell:enh_dashoffset

Nov 24, 2015

Merged

ENH: pass dash_offset through to gc for Line2D#5433

mdboom merged 4 commits intomatplotlib:masterfromtacaswell:enh_dashoffset

Nov 24, 2015

Conversation

Copy link

Member

tacaswell commentedNov 7, 2015

Previously, the user supplied offset to Line2D set_linestyle
was silently discarded. This commit makes the value to be passed
through to the underlying GC on draw, but not all of the backends do
anything with the offset (ex Agg does not).

tacaswell added the status: needs review label

Nov 7, 2015

tacaswell mentioned this pull request

Nov 7, 2015

Linestyle: dash tuple with offset#5430

Closed

tacaswell added this to theunassigned milestone

Nov 8, 2015

tacaswell added status: needs revision and removed status: needs review labels

Nov 8, 2015

Copy link

Member

mdboom commentedNov 12, 2015

See my enh_dashoffset branch. I fixed the Agg backend and the PostScript backend. All other backends seemed to already work. (Can't make PR against this because we have too many forks and I can't set yours as the base ?!?)

We should add a test based on your example in#5430.

Copy link

MemberAuthor

tacaswell commentedNov 12, 2015

We have emailed gh about that issue, we are just too big. The work around
is url hacking as the bug is in generating the drop down menu.

On Thu, Nov 12, 2015, 09:02 Michael Droettboomnotifications@github.com
wrote:

See my enh_dashoffset branch. I fixed the Agg backend and the PostScript
backend. All other backends seemed to already work. (Can't make PR against
this because we have too many forks and I can't set yours as the base ?!?)
We should add a test based on your example in#5430
#5430.
—
Reply to this email directly or view it on GitHub
#5433 (comment)
.

tacaswell added status: needs review and removed status: needs revision labels

Nov 24, 2015

tacaswell modified the milestones:proposed next point release (2.1),unassigned

Nov 24, 2015

tacaswell added status: needs revision and removed status: needs review labels

Nov 24, 2015

tacaswelland others added4 commits

November 24, 2015 00:23

ENH: pass dash_offset through to gc for Line2D

50aceb5

Previously, the user supplied offset to Line2D set_linestylewas silently discarded.  This commit makes the value to be passedthrough to the underlying GC on draw, but not all of the backends doanything with the offset (ex Agg does not).

Make dash offset work in Agg backend

2df0840

Make dash offset work in PostScript backend

5e75800

TST: add test of dash offsets

9ee4e99

tacaswell force-pushed theenh_dashoffset branch fromddeec98 to9ee4e99Compare

November 24, 2015 05:24

tacaswell added status: needs review and removed status: needs revision labels

Nov 24, 2015

Copy link

MemberAuthor

tacaswell commentedNov 24, 2015

I think this is ready to go.

mdboom added a commit that referenced this pull request

Nov 24, 2015

Merge pull request#5433from tacaswell/enh_dashoffset

06a08e3

ENH: pass dash_offset through to gc for Line2D

mdboom merged commit06a08e3 intomatplotlib:master

Nov 24, 2015

mdboom removed the status: needs review label

Nov 24, 2015

mdboom modified the milestones:next major release (2.0),proposed next point release (2.1)

Dec 11, 2015

Copy link

Member

mdboom commentedDec 11, 2015

Backported to 2.0.x asd11e344

mdboom added a commit that referenced this pull request

Dec 11, 2015

Merge pull request#5433from tacaswell/enh_dashoffset

d11e344

ENH: pass dash_offset through to gc for Line2D

mdboom mentioned this pull request

Dec 11, 2015

Backport #5307 to v2.0.x#5652

Merged

tacaswell deleted the enh_dashoffset branch

December 13, 2015 04:46

Copy link

Contributor

afvincent commentedJun 1, 2016

Intest_dash_offset(), is it normal to haveplt.show() at the end of the test? I just ask this because when I runtest_axes in an IPython session, it is the only test that plots something on my screen (and waits for me to close the window to finish the other tests, as plt.ion() is not used).