Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change default interpolation to nearest#5416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

jenshnielsen
Copy link
Member

#4622 agains 2.0.x

@jenshnielsen
Copy link
MemberAuthor

There is something seriously wrong somewhere

This causes matplotlib.tests.test_image.test_get_window_extent_for_AxisImage to segfault at least on python 3.5

@jenshnielsen
Copy link
MemberAuthor

Furthermore a fair number of tests fail due to the change. They don't seem to pickup the classic style

@mdboom
Copy link
Member

I don't think the test suite has been set up to forcibly use the classic style yet.

@jenshnielsen
Copy link
MemberAuthor

Ok the seqfault is genuine thou

@jenshnielsen
Copy link
MemberAuthor

I thought this was supposed to set it up to use the classic stylehttps://github.com/matplotlib/matplotlib/blob/v2.0.x/lib/matplotlib/testing/decorators.py#L232

@WeatherGod
Copy link
Member

It was set up to use the classic style for any image comparison test.
Something is wrong if it isn't doing that.

On Fri, Nov 6, 2015 at 9:33 AM, Jens Hedegaard Nielsen <
notifications@github.com> wrote:

I thought this was supposed to set it up to use the classic style
https://github.com/matplotlib/matplotlib/blob/v2.0.x/lib/matplotlib/testing/decorators.py#L232


Reply to this email directly or view it on GitHub
#5416 (comment)
.

@mdboom
Copy link
Member

Sorry, I missed that. I was expecting to see that in the cleanup decorator, not the image comparison one.

@jenshnielsen
Copy link
MemberAuthor

The segfault is on master toohttps://travis-ci.org/matplotlib/matplotlib/jobs/89776539
see#5429

@jenshnielsen
Copy link
MemberAuthor

rebased to fix the segfault

mdboom added a commit to mdboom/matplotlib that referenced this pull requestNov 8, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull requestNov 8, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull requestNov 8, 2015
@mdboommdboom mentioned this pull requestNov 8, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull requestNov 8, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull requestNov 11, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull requestNov 13, 2015
mdboom added a commit to mdboom/matplotlib that referenced this pull requestNov 16, 2015
@tacaswell
Copy link
Member

@mdboom is this folded into your style branch?

@mdboom
Copy link
Member

@mdboom is this folded into your style branch?

Yes. And related to this (for the record) I think we should also setimage.resample toTrue by default (see the discussion in#5718)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

4 participants
@jenshnielsen@mdboom@WeatherGod@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp