Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove uses of font.get_charmap#5410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -1,8 +1,6 @@ | |||
| """ | |||
| font data tables for truetype and afm computer modern fonts | |||
| """ | |||
| # this dict maps symbol names to fontnames, glyphindex. To get the | |||
| # glyph index from the character code, you have to use get_charmap | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This comment is out of date and should have been removed in#5299.
looks good to me. Is this intended to be backported anywhere? |
also, is there any plan to mark |
Yes, to 2.0 which can benefit from this for the larger fonts.
Longer term (probably 2.1, though I'm not promising that as a dealine), this will all be replaced by matplotlib/freetypy. See my freetypy branch. |
MNT: Remove uses of font.get_charmap
This does not backport cleanly, I will have a PR soon |
MNT: Remove uses of font.get_charmapConflicts: lib/matplotlib/tests/test_font_manager.pyConflicts with merging the tests, resloved to add only relavent code.
Merge pull request#5410 from mdboom/get-charmap-removal
Backported via#5412. |
This is a follow-on to#5299 and removes all other uses of
FT2Font.get_charmapin the code base (and these ones were a lot easier). Again, this helps a lot with large Unicode fonts since we don't have to generate a large dictionary just to access the handful of characters any one plot contains.