Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Remove various Python 2.6 related workarounds#5373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
45f5f30 todc7debcCompareThe changes look good to me, and the tests are passing. I guess one question may be whether we want to error out immediately when running in 2.6, or just give a warning and try to run in any case, since at least the way I understood the announcement as merely withdrawing "official support". |
With#5299 merged (which depends on functool32 which is python 2.7 and later only) I think we have broken 2.6 support fully. This should not go into 1.5.x which should still work with 2.6 |
You're right, Python 2.6 won't run current master. 👍 |
~~We may also want to consider a friendly error message on Python 2.6 from which refers to functools32, which might lead to a bug report tous. Better to just say "matplotlib requires 2.7, 3.3, 3.4 or 3.5" and be done with it.~~ EDIT: Sorry, I missed the check in setupext.py. That's great. |
CLN: Remove various Python 2.6 related workarounds
CLN: Remove various Python 2.6 related workarounds
back-ported to v2.0.x as1866a8c |
joranbeasley commentedFeb 14, 2017
can you at least tell me which version i should install if i do want py2.6? |
v1.5.3 should support 2.6, IIRC …On Tue, Feb 14, 2017 at 3:35 PM, joranbeasley ***@***.***> wrote: can you at least tell me which version i should install if i do want py2.6? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5373 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARy-OEo5KHA1CraQNwDqA-KYRQO3OD_ks5rchAqgaJpZM4GZeX9> . |
The 1.4 series is the last versions to officially support python 2.6. There was a loing discusion about this in 2015http://matplotlib.1069221.n5.nabble.com/Matplotlib-devel-supported-python-versions-tt46154.html and no one volunteered to take care of 2.6 compatible branch so it got dropped. @joranbeasley I have deleted your comment. Insulting core maintainers (who are volunteers) is not condusive to us taking your concerns seriously. Please be civil in our channels. |
Thomas is right. v1.4.x was the last one to support py26. My memory wasfaulty. …On Tue, Feb 14, 2017 at 3:51 PM, Thomas A Caswell ***@***.***> wrote: The 1.4 series is the last versions to officially support python 2.6. There was a loing discusion about this in 2015http://matplotlib.1069221.n5.nabble.com/Matplotlib-devel- supported-python-versions-tt46154.html and no one volunteered to take care of 2.6 compatible branch so it got dropped.@joranbeasley <https://github.com/joranbeasley> I have deleted your comment. Insulting core maintainers (who are volunteers) is not condusive to us taking your concerns seriously. Please be civil in our channels. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5373 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AARy-DdObTPxJkJ1qJPjo6jhG6zz_mbzks5rchPugaJpZM4GZeX9> . |
Now that we don't support 2.6 any more we might as well get rid of this. This is what I found from grepping the code so there might as well be more that we can delete.
I also fixed the version check in
__init__we might want to backport that to 2.0.x