Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
fix #4854: set default numpoints of legend entries to 1#5131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
The classic style should have numpoints=2, The idea of the classic style is to provide a style that exactly replicates how MPL looked before the default changes. |
Also apparently the test-images must be updated when the PR is ready. |
No the tests run with the classic style as default to avoid having to update all the test images. |
Please don't merge this until we have pushed the 1.5 development off the master branch. |
Hmmm, that is strange that only the legend_expand tests failed. Could that codepath be utilizing rcparams incorrectly? |
@gauteh Can you rebase? I believe something has corrected the failure on master. |
fix#4854: set default numpoints of legend entries to 1
Backported as part of#5774. |
check#4854: set default numpoints to 1.
I am a bit unsure abouth wether classic.mplstyle should be changed.