I've found a way to figure out whether we need to use the HiDPI icons (i.e. what the screen resolution is). I'll work on it later this week.

It looks like qt understands svg, could we use those instead of hi-res pngs?

http://doc.qt.io/qt-5/qimagereader.html#supportedImageFormats

@tacaswell - ah, certainly! I had not realized that. I will work on that in a few days.

@tacaswell - although it looks like this was actually changed from SVGto PNG in the past for Qt4:

c61df40

#143

http://sourceforge.net/p/matplotlib/mailman/matplotlib-users/thread/4D4EA423.5090802@vanderHoeven.biz/

Sounds like this caused some issues on Windows? This was 4 years ago though, so maybe things have changed?

attn@jbmohler@mfitzp Do either of you have experience with py2exe + qt ?

@tacaswell - how do you think we should proceed on this? Is there anyone else who might be able to advise on what to do here re: PNG vs SVG?

I am not sure,py2exe seems to be a persistent thorn in our side in general and I have no windows experience.

I know@jrevans has recently done a lot of work porting a Qt app over to Qt5, he might have some insight here (not sure what platform they run on).

@tacaswell I've not used py2exe before. But from the mailing list link it looks like the change to PNG was more due to a packaging issue (i.e. py2exe wasn't bundling the required xml handler). I have a Windows machine available I can test this on. On Qt5 Svg I think rendering is handled by a separate Qt.Svg module so I suspect there will be the same problem, but with a different fix. There are also the image format plugins that may need to be triggered.

Making this work may just be a case of including the Svg/other import in ourqt_compat.py. The linked post says that this didn't work, but that may be a case of where to do the import + what exactly to import.

We are adding more files tolib/matplotlib/mpl-data/images/ without any organization or control.

I really don't like the hand adding of icons of different sizes and hand naming is even worst.

Why don't we use a script to convert the sourcesvg to different sizes automatically at build, generating different40x40_, 60x60_... 1280x1280_ orsmall_, medium_... xxlarge_?

With an automatic icon creation, we are sure the size that we are requesting in the format that we are requesting will be there.

With an automatic icon creation, we are sure the size that we are requesting in the format that we are requesting will be there.

Just FYI: I'm working on this.

I think this is now fixed in master? (with the new icons)

Confirming that Qt5Agg and the OSX backend have HiDPI icons on HiDPI screens Thanks@astrofrog