NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Qt5: Add flag that informs paintEvent if the agg buffer needs to updated, fix rubberband#4962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

pwuertz wants to merge3 commits intomatplotlib:masterfrompwuertz:qt5_agg_redraw_flag

Closed

Qt5: Add flag that informs paintEvent if the agg buffer needs to updated, fix rubberband#4962

pwuertz wants to merge3 commits intomatplotlib:masterfrompwuertz:qt5_agg_redraw_flag

Conversation

Copy link

Contributor

pwuertz commentedAug 19, 2015

Added a flag for determining if paintEvent needs to update the agg buffer or not. The buffer is updated when draw_idle triggers the paintEvent and the buffer is considered valid after using draw and when using blit.

Discussion in#4943, Speed up Example in#4947

tacaswell added the status: needs review label

Aug 19, 2015

tacaswell reviewed

Aug 19, 2015

View reviewed changes

lib/matplotlib/backends/backend_qt5agg.py

		@@ -71,7 +71,11 @@ def paintEvent(self, e):
		In Qt, all drawing should be done inside of here when a widget is
		shown onscreen.
		"""
		FigureCanvasAgg.draw(self)
		if not hasattr(self, "_agg_redraw_flag"):

Copy link

Member

tacaswellAug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This should go in the init so it is always defined.

Copy link

ContributorAuthor

pwuertzAug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It should, but this is seems to be a Mixin for which the init method is not called at all.

Copy link

Member

tacaswellAug 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Then we should fixthat problem as well.

tacaswell added this to thenext point release milestone

Aug 19, 2015

pwuertz mentioned this pull request

Aug 20, 2015

Lasso-ing in WxAgg causes flickering of the entire figure#4968

Closed

pwuertz added3 commits

August 20, 2015 10:25

Qt5: Add flag that informs paintEvent if the agg buffer needs to upda…

05ded3b

…ted, init FigureCanvasQTAggBase

Add handler for removing the rubberband when zoom is released

4414a7a

Fix rubberband removal in Qt backend

d39932a

pwuertz changed the title~~Qt5: Add flag that informs paintEvent if the agg buffer needs to updated~~Qt5: Add flag that informs paintEvent if the agg buffer needs to updated, fix rubberband

Aug 20, 2015

Copy link

ContributorAuthor

pwuertz commentedAug 20, 2015

Added two new commits for fixing the rubberband in qt. The first adds aremove_rubberband() handler tobackend_bases that is invoked when the zoom rectangle is released.

The other commit changes the rubberband handling in the qt backend to utilize the rubberband removal handler. The previous solution was to simply remove the rectangle after each draw. This method fails when there is an additional paintEvent between twodraw_rubberband() calls because it clears the rubberband while it is still being dragged (flicker). Also, there is the chance that the paintEvent requested by the lastdraw_rubberband() call before releasing the mouse might get delayed until after thedraw_idle() call for zooming in. This causes the rubberband to be drawn on top of the zoomed-in figure (bad) and since there are no more events after the release the rubberband will stay on screen (worse).

Also, changing the state of the rubberband doesn't trigger an agg buffer redraw anymore, freeing some CPU cycles while dragging.