Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
FIX: argument order in RendereAgg.restore_region#4951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Inba40160 Remove use of PyCXX in core C++ extensions the orderof the arguments into the `restore_region` that takes off setswas swapped. The order should be (x1, x2, y1, y2, offset_x, offset_y)which was the order of `restore_region2` (a function removed as partof the refactor in favor of simple dispatch in the wrapper code +c++ function overloading) and the order of the arguments passedout of the python layer, but at the c++ layer they were being mappedto (offset_x, offset_y, x1, x2, y1, y2) which was causing a regionnot of interest to be restored.closesmatplotlib#4947
WeatherGod added a commit that referenced this pull requestAug 18, 2015
FIX: argument order in RendereAgg.restore_region
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inba40160 Remove use of PyCXX in core C++ extensions the order
of the arguments into the
restore_regionthat takes off setswas swapped. The order should be (x1, x2, y1, y2, offset_x, offset_y)
which was the order of
restore_region2(a function removed as partof the refactor in favor of simple dispatch in the wrapper code +
c++ function overloading) and the order of the arguments passed
out of the python layer, but at the c++ layer they were being mapped
to (offset_x, offset_y, x1, x2, y1, y2) which was causing a region
not of interest to be restored.
closes#4947