Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Document mpl_toolkits.axes_grid1.anchored_artists#4874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -1,43 +1,152 @@ | |||
| from __future__ import (absolute_import, division, print_function, | |||
| unicode_literals) | |||
| from matplotlib.externals import six | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please leave the six import even if it isn't used to keep our files consistent.
I think this is ready to merge once you address@tacaswell's minor comment. |
merged#4864 cycled open/close to re-trigger travis on new master |
Remove non-library (and unusable) codeRemove unused importsFixed pylint issues with indentation
Add explicit setting of __all__ to prevent similiar errors
63c4e92 toaeb2a2eCompare1802aa4 to34d1937CompareI've rebased, readded the I did have to change one of the examples which imported |
| if __name__ == "__main__": | ||
| import matplotlib.pyplot as plt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Is it worth moving this code to an example?
Document mpl_toolkits.axes_grid1.anchored_artists
Document mpl_toolkits.axes_grid1.anchored_artistsConflicts:lib/mpl_toolkits/axes_grid1/anchored_artists.pyNote that the removed imports were restored for this backport so as tonot break the API for 2.0. Whether they really should be moved or not isa matter for a different PR.
Backported to v2.x viaef06f5f. |
Here's another PR following up on#4864.
The documentation isn't built with this commit, but I'll
push another commit (or open another PR if this is already merged) to add the API docs
to doc/mpl_toolkits/axes_grid/api/index.rst once PR#4864 is merged.