Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
[mpl_toolkits] Allow "figure" kwarg for host functions in parasite_axes#4863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@@ -487,7 +487,10 @@ def host_axes(*args, **kwargs): | |||
import matplotlib.pyplot as plt | |||
axes_class = kwargs.pop("axes_class", None) | |||
host_axes_class = host_axes_class_factory(axes_class) | |||
fig = plt.gcf() | |||
if kwargs.get("figure") != None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
don't do equality comparison toNone
. Always dois
andis not
.
Also needs documentation (although, I am not clear where...). Besides the equality comment, this makes sense to me. Don't know why it wasn't coded that way before... |
@WeatherGod thanks for your correction. Both of these functions weren't documented (except for their usage in examples) to begin with, so I'm not sure either. The whole AxesGrid toolkit seems a bit neglected to me, do people still use it? |
Oh, absolutely it gets used. It is one of the more popular toolkits. On Tue, Aug 4, 2015 at 5:23 PM, productivememberofsociety666 <
|
Someone else just contributed some docs:#4864 |
In fact, you might be interested in#4864 (just submitted) where someone gives some love to the documentation. |
import matplotlib.pyplot as plt | ||
axes_class = kwargs.pop("axes_class", None) | ||
host_axes_class = host_axes_class_factory(axes_class) | ||
fig = plt.gcf() | ||
if kwargs.get("figure") is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would do this as
fig=kwargs.get('figure',None)iffigisNone:fig=plt.gcf()
Sorry this languished, in the future leave a comment after you finish with edits. We don't get notifications on commit pushes, just comments. |
…xes_not_pyplotENH: Allow "figure" kwarg for host functions in parasite_axes
This isn't perfect, but does not make it worse. |
FilipDominec commentedSep 26, 2016
Could you, please, point me to a minimum example of using self.fig=matplotlib.figure.Figure(figsize=(8,8)) is defined? |
smheidrich commentedSep 30, 2016 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
hax=host_axes([0.1,0.1,0.8,0.8],figure=fig)hax.plot([0,1,2,3],[1,2,4,8])fig.savefig("some_file.png") Result looks very broken though, even when I set I'm using |
FilipDominec commentedSep 30, 2016
@smheidrich Thanks! |
Currently,
host_axes
andhost_subplot
ofmpl_toolkits.axes_grid1
work onpyplot
only. This patch allows a kwargfigure
(defaulting topyplot.gcf()
) to be passed so it becomes possible to use them on arbitrary figures as well.