At first blush, this looks like a nice simplification. Ping me to come back and look again as it progresses.

One possible further simplification:

Maybe include a defaultstale_callback method that is a no-op, rather than requiringif self.stale_callback is not None everywhere it is called? That seems like the kind of thing that could be forgotten down the road.

@tacaswell

Isn't the call to draw_idle the message to the canvas that it is stale?

Yes it is. "draw_idle" is a bit of a misnomer; "invalidate" may be better. The purpose of draw_idle is to let the canvas know that it is stale. How the canvas responds to that is up to the backend. Typically, a GUI backend will indeed schedule a redraw when the event loop is idle, but I could imagine that in specific backends draw_idle does something else (e.g. set a flag or something). Not sure if this is what you were asking, but anyway I hope it helps.

@mdehoon I disagree about the purpose ofdraw_idle, it is to instruct the canvas that it should redraw at the next opportunity (vsdraw which is telling the canvas to re-renderright now). The details of how this is implemented is up to the backends (and in the case of macosx you deal with this by having an 'invalid' flag which the draw loop knows to mean it should re-draw on this cycle through), but other wise the canvas objects are (publicly) stateless and the implementation in backend bases to passdraw_idle through todraw (which really only matters for agg in terms of the backends we ship) is perfectly correct.

Trying to implement this highlighted a design choice that did not get articulated in my conversation with@mdehoon is mpl's idea of where the stale/invalid state should live is in scene graph tree or in the canvas. As I have implemented it, it lives in the scene graph, as@mdehoon wants it (and as it is explicitly implemented in macosx, explicitly as part ofdraw_idle in some backends, and deep in the guts of Qt currently) the state lives on the canvas side.

I think the arguments for doing this on the scene graph side are:

• will work with backends we do not ship (I know of at least 2 in the wild)
• will work with use-cases where the scene graph does not have a canvas associated with it (not relevant now, but pure export based work flows are coming).
• requires changing less code

Although I admittedly have trouble coming up with a good use case, but forcing users into our idea of what the draw cadence should be seems wrong (but on the other hand, just turning interactive mode off seems to be the cut-out).

@tacaswell Just for clarification,

in the case of macosx you deal with this by having an 'invalid' flag which the draw loop knows to mean it should re-draw on this cycle through

as it is explicitly implemented in macosx

There is no explicit 'invalid' flag in the macosx backend; currently draw_idle in the macosx backend simply calls canvas.invalidate(), which (in the C code) calls Apple's API function to schedule a redraw. There may be some 'invalid' flag hidden deep in Apple's libraries, but there is no explicit 'invalid' flag within matplotlib. In this sense it is similar to Qt.

Tkagg is different as it draws to _tkphoto, which then needs to be blitted explicitly.