Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Figure property#4842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Figure property#4842
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @figure.setter | ||
| def figure(self, fig): | ||
| self._figure = fig |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you are going to do this you should add validation that artists can not be moved between figures.
I would not go down this road right now, there is an on-going effort to change all of the Artist attributes into traitlets (#4762) which will supercede this. Sorry for the poor communication and I hope you didn't spend too much time on this! |
Okay, if the attributes are being changed to traitlets, I guess it's good. I don't know about it too much, so I cannot foresee exactly all the gain the project will get from this switch. |
If you want to help with traitlets coordinate with@rmorshea At a minimum we need help with testing, etc of that branch. Something as simple as using the traitlets branch for you daily work would be great. Hopefully once Ryan gets the general work flow worked out, up-converting attributes -> traitlets can be parallelized. |
What was done:
deprecated_get_setfunctionI know the deprecation helper is in a weird place, and I am more than willing to change it, but I had no idea where to put it...
Also, I plan on transforming other attributes (as much as possible) to properties, if you think it is a good idea. If so, do you want a PR per attribute or should I group them?