Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fixes to funcanimation#4800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 4 commits intomatplotlib:masterfromjenshnielsen:funcanimfixes
Jul 31, 2015
Merged

Conversation

jenshnielsen
Copy link
Member

While reviewing#4785 I discovered a few issues with the decay animation example:

  1. The example does not reset the plotted data when the animation is rerun/resaved after having been running/saved once. To solve this I added an init function to resets the animation.
  2. The init function is only called at construction time and not when restarting the animation so the above doesn't work. I adapted the code to make sure that init is called at both the beginning of a save sequence and when showing the animation.
  3. When saving the figure more than once or showing and saving the animation the second version of the animation contains wrong frames (the first frame at the end or missing frames in the beginning an so on) This is caused by the animation iterating over_save_seq and updating_save_seq while iterating. I have fixed this by copying_save_seq before iterating.

@dopplershift does this make sense or do you see a better way of fixing these issues?

@dopplershift
Copy link
Contributor

Looks good to me. Just waiting on Travis to confirm all good.

@tacaswelltacaswell added this to thenext point release milestoneJul 28, 2015
tacaswell added a commit that referenced this pull requestJul 31, 2015
@tacaswelltacaswell merged commit5c58ea9 intomatplotlib:masterJul 31, 2015
dopplershift added a commit to dopplershift/matplotlib that referenced this pull requestAug 4, 2015
This was introduced bymatplotlib#4800. We need to disconnect the initial drawcallback in _start() before doing _init_draw(), otherwise, we end upback in _start() when the draw_event fires.Also go ahead and remove the call to _init_draw() in __init__(), since_start() will handle it.
@jenshnielsenjenshnielsen deleted the funcanimfixes branchAugust 20, 2015 12:42
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestAug 27, 2015
This was introduced bymatplotlib#4800. We need to disconnect the initial drawcallback in _start() before doing _init_draw(), otherwise, we end upback in _start() when the draw_event fires.Also go ahead and remove the call to _init_draw() in __init__(), since_start() will handle it.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

3 participants
@jenshnielsen@dopplershift@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp