Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Fixes to funcanimation#4800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…lling init both when showing and saving
Ensures that the plot is cleared before restarting the animation
Looks good to me. Just waiting on Travis to confirm all good. |
dopplershift added a commit to dopplershift/matplotlib that referenced this pull requestAug 4, 2015
This was introduced bymatplotlib#4800. We need to disconnect the initial drawcallback in _start() before doing _init_draw(), otherwise, we end upback in _start() when the draw_event fires.Also go ahead and remove the call to _init_draw() in __init__(), since_start() will handle it.
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestAug 27, 2015
This was introduced bymatplotlib#4800. We need to disconnect the initial drawcallback in _start() before doing _init_draw(), otherwise, we end upback in _start() when the draw_event fires.Also go ahead and remove the call to _init_draw() in __init__(), since_start() will handle it.
This was referencedNov 4, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While reviewing#4785 I discovered a few issues with the decay animation example:
_save_seq
and updating_save_seq
while iterating. I have fixed this by copying_save_seq
before iterating.@dopplershift does this make sense or do you see a better way of fixing these issues?