Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MEP12 on alignment_test.py#4653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

domspad
Copy link

pylab to plt

jenshnielsen added a commit that referenced this pull requestJul 12, 2015
@jenshnielsenjenshnielsen merged commit58064c3 intomatplotlib:masterJul 12, 2015
@jenshnielsenjenshnielsen added the MEP: MEP12gallery and examples improvements labelJul 12, 2015
@domspad
Copy link
Author

hey@jenshnielsen, just a quick clarification on these pull requests - since we are just correcting thefrom pylab import * parts of the#2474 (MEP12) issue right now with these examples. If I make any more changes to them with regards to the other bullet points in MEP12, should they be in a new branch? Or can I continue on this branch even though it is closed?

@jenshnielsen
Copy link
Member

@domspad Thanks for all your work. You can continue on the same branch as long as the pull request is not merged when it is merged please open a new one to make more changes. You can probably open a new pull request from the same branch (Github should automatically detect that some of the commits have been merged) but for clarity I would recommend that you open a new one.

@jenshnielsen
Copy link
Member

@domspad however if you want to do more work on an open pull request please just leave a note about not merging it, or better edit the title to say don't merge yet or something.

@domspaddomspad deleted the MEP12-on-alignment_test.py branchJuly 14, 2015 02:57
@WeatherGod
Copy link
Member

I usually add a "[WIP]" to the name of the PR if it is a work in progress.
On Jul 13, 2015 9:44 PM, "Jens Hedegaard Nielsen"notifications@github.com
wrote:

@domspadhttps://github.com/domspad however if you want to do more work
on an open pull request please just leave a note about not merging it, or
better edit the title to say don't merge yet or something.


Reply to this email directly or view it on GitHub
#4653 (comment)
.

@QuLogicQuLogic added this to thev1.5.0 milestoneNov 4, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
MEP: MEP12gallery and examples improvements
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

5 participants
@domspad@jenshnielsen@WeatherGod@tacaswell@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp