Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Change default interpolation to nearest#4622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
a37968a to6dff273CompareNeed to refresh the following tests matplotlib.tests.test_axes.test_specgram_angle_freqs.test |
Changing to "nearest" makes sense to me; I have never seen the present default as useful. |
👍 |
| @@ -714,8 +714,8 @@ class NonUniformImage(AxesImage): | |||
| def __init__(self, ax, **kwargs): | |||
| """ | |||
| kwargs are identical to those for AxesImage, except | |||
| that 'interpolation' defaults to 'nearest', and 'bilinear' | |||
| is the only alternative. | |||
| that 'nearest', and 'bilinear' are the only supported 'interpolation' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should the comma be removed between "nearest" and "and 'bilinear'"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@maxalbert yes
I agree with this change. However, the one downside is that it will increase file sizes for the vector backends (since the data will now be upsampled to the output resolution). We should probably include that as a note in the "What's new" about this change. |
Doesn't that depend on whether the default is 'none' versus 'nearest'? On Mon, Jul 13, 2015 at 12:47 PM, Michael Droettboom <
|
@WeatherGod: You're right. Ignore my comment. |
👍 for changing to nearest by default |
jradavenport commentedOct 5, 2015
👍 for nearest. I'm seeing more and more figures making it in to published literature using 'none', which are unreadable. Changing this default would promote best-practices for scientific figures. |
CLN: Remove various Python 2.6 related workarounds
Fixmatplotlib#347: Faster text rendering in Agg
FIX: Apply asanyarray to arguments for pcolor and family
DOC: correct indentation
…ndentMerge pull requestmatplotlib#5407 from tacaswell/doc_boxplot
MNT: Remove uses of font.get_charmapConflicts: lib/matplotlib/tests/test_font_manager.pyConflicts with merging the tests, resloved to add only relavent code.
Merge pull requestmatplotlib#5410 from mdboom/get-charmap-removal
Use a specific version of Freetype for testing
6dff273 todd2cb75Comparereplaced by#5416 against the correct branch and with the typo fixed |
As discussed in the Scipy BOF I propose changing the default interpolation of imshow to nearest.
I haven't yet refreshed any of the tests. So this will likely fail.