Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Only use asynchronous redraw methods when handling GUI events in Qt5Agg (fix #4604)#4612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
For testing purposes I removed the update/redraw() switch for windows that was introduced because windows users reported a insufficient amount of actual redraws on Qt4Agg/Win. It could be possible that this was actually the same problem back then if Qt4/Win emitted events more frequently than Qt4/X11 or Qt4/OSX. Could a Windows user confirm that Qt5Agg is working fine with this PR? |
The |
I can confirm both the bug and that this fixes it. Both the qt4 and qt5 backends work fine wrt pan/zoom updates for me with this. I am going to merge this now and make a note with the RC that this will need testing on mac + windows. |
FIX: Only use asynchronous redraw methods when handling GUI events in Qt5AggFix#4604
When handling events like mouse movements during zoom/pan, the Qt5 backend forced a redraw of the Agg canvas for every event. Redraw operations should be done only when the GUI is ready to display another frame, else the rendering performance is going to be crushed on systems where Qt emits events more frequently.