Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.2k
Add Seaborn style sheets; addresses #4566#4570
Conversation
efiring commentedJun 30, 2015
Thanks for doing this. |
petebachant commentedJun 30, 2015
I was thinking of calling this one simply |
efiring commentedJun 30, 2015
Attn@mwaskom: comments? |
mwaskom commentedJun 30, 2015
I would prefer the current default seaborn style to be called Do matplotlib stylesheets have any facility for handling style and element scale ("context" in seaborn, regrettably) independently? |
WeatherGod commentedJun 30, 2015
There is MEP26 that is being ironed out, if that is what you are thinking? On Tue, Jun 30, 2015 at 3:59 PM, Michael Waskomnotifications@github.com
|
mwaskom commentedJun 30, 2015
I just mean that the "seaborn styles" are really the product of two independent sets of rc parameters. |
petebachant commentedJun 30, 2015
The scaling and colors could be split into two different stylesheets, which would allow users to |
mwaskom commentedJun 30, 2015
Actually good point, you also need a third piece: the color cycle palette. |
tacaswell commentedJun 30, 2015
Would it be worth adopting the scale style sheets wholesale so ? The color cycle might be complicated / should embrace#4258 (which needs to be replaced by a PR to addhttps://github.com/tacaswell/cycler (which needs to end up on pypi and move to the mpl org) ). |
mwaskom commentedJun 30, 2015
I don't think seaborn does anything as complicated as your cycler tool, it just sets the color cycle independently from the axes style and plotting context. |
tacaswell commentedJul 2, 2015
Right, leave cycler out of this. @petebachant Can you split the style sheet up as discussed (base axes settings, font/tick sizes, color cycle)? There is a PR in to use styles in styles (#4240 ) which can be used to create composite style sheets if we want that as well. |
petebachant commentedJul 3, 2015
Sure, I will split the style sheets up. |
petebachant commentedJul 4, 2015
Just split the darkgrid style into three sheets for the scaling, colors, and palette. What do you guys think? Should I make the other Seaborn variants? |
tacaswell commentedJul 4, 2015
👍 to both this and the other variants. |
tacaswell commentedJul 5, 2015
@petebachant I am going to merge this as-is, can you make a new PR with the other variants ? |
ENH: Add Seaborn style sheetscloses#4566
petebachant commentedJul 6, 2015
Will do! |
This commit adds the default Seaborn "darkgrid" style to the style library.