Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Raise missing ValueError in transform_angles#4458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Raise missing ValueError in transform_angles#4458
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| new_angles = t.transform_angles(angles, points) | ||
| assert_array_almost_equal(angles, new_angles) | ||
| with assert_raises(ValueError) as cm: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
for future coders, could you add a comment explaining the error you are triggering?
I restarted the failing test, now it is saying that |
@WeatherGod Assert_raises can't be used as a context manager in python 2.6. I would suggest just skipping this test on python 2.6 as done inhttps://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/tests/test_rcparams.py#L127 |
Didn't know that. Good to know! On Sat, May 23, 2015 at 10:56 AM, Jens Hedegaard Nielsen <
|
- Includes a small PEP8 change- Added tests to cover the `Transform.transform_angles` method
d3254ec to06d0892CompareWell, that worked this time around. Commented the tests. |
Raise missing ValueError in transform_angles
This does not need backporting. The exception was only missing in master. |
@has2k1 Thanks! I should have caught that. |
Transform.transform_anglesmethod