Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Reorder the code in the draw() method of Line2D to fix issue 4338#4348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
@mdehoon Thanks. Looks good to me, I will merge as soon as travis agrees. I will also back-port this to the color_overhaul branch. |
tacaswell added a commit that referenced this pull requestApr 17, 2015
FIX : Reorder the code in the draw() method of Line2Dfixes#4338
tacaswell added a commit that referenced this pull requestApr 17, 2015
FIX : Reorder the code in the draw() method of Line2Dfixes#4338
Member
tacaswell commentedApr 17, 2015 • edited by QuLogic
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by QuLogic
Uh oh!
There was an error while loading.Please reload this page.
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, I reordered the lines in the draw() method of Line2D to first check if funcname != '_draw_nothing' before starting to fill in the graphics context. The first call to new_gc moved to after this check; this fixes the bug described in issue 4338.