Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Labels do not becomes color anymore in figure options panel for qt toolb...#4304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -61,6 +61,8 @@ | |||
| import datetime | |||
| BLACKLIST = ["Title", "Label"] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would make these all lower case
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Can you also use aset, trivial performance gain...
Ok, added the set improvement. Better if the blacklist increases one day ! But the label.lower() seems to cost a lot too. Maybe check against the "brute" label is better ? |
The performance optimizations on the In most cases, it is simpler to normalize strings before checking them for being in the set rather than including all permutations of capitalization you want to support. |
BUG : never treat title or label values as colors in qt_editorfixes#4303
@Acanthostega Thank you! I think this is your first mpl contribution, congratulation! |
Filtering by labels is sufficient, not clean, but working.
Are you interested in making a rigid but clean widget to avoid such problems in the future ? If yes, I can probably do it in two or three weeks, when I will have sufficient time.