Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
ENH : Nbagg blit#4290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
ENH : Nbagg blit#4290
Uh oh!
There was an error while loading.Please reload this page.
Conversation
attn@pelson |
Also closes#4287 |
attn@blink1073 This might be relevant for scikit-image's stuff. |
Ooh, shiny! I'll check it out tonight. |
This appears to have broken UAT 13 - Animation. If I run the all of the cells, it yields an empty figure. If I try and run it again, I get a static line with an animated line running through it, and this error: ERROR:tornado.application:Exceptionincallback<boundmethodTimerTornado._on_timerof<matplotlib.backends.backend_nbagg.TimerTornadoobjectat0x109d78450>>Traceback (mostrecentcalllast):File"/Users/stevensilvester/Library/Python/2.7/lib/python/site-packages/tornado/ioloop.py",line989,in_runreturnself.callback()File"/Users/stevensilvester/workspace/matplotlib/lib/matplotlib/backend_bases.py",line1290,in_on_timerret=func(*args,**kwargs)File"/Users/stevensilvester/workspace/matplotlib/lib/matplotlib/animation.py",line925,in_stepstill_going=Animation._step(self,*args)File"/Users/stevensilvester/workspace/matplotlib/lib/matplotlib/animation.py",line784,in_stepself._draw_next_frame(framedata,self._blit)File"/Users/stevensilvester/workspace/matplotlib/lib/matplotlib/animation.py",line804,in_draw_next_frameself._post_draw(framedata,blit)File"/Users/stevensilvester/workspace/matplotlib/lib/matplotlib/animation.py",line827,in_post_drawself._blit_draw(self._drawn_artists,self._blit_cache)File"/Users/stevensilvester/workspace/matplotlib/lib/matplotlib/animation.py",line841,in_blit_drawbg_cache[a.axes]=a.figure.canvas.copy_from_bbox(a.axes.bbox)File"/Users/stevensilvester/workspace/matplotlib/lib/matplotlib/backends/backend_webagg_core.py",line196,incopy_from_bboxrenderer=self._last_rendererAttributeError:'FigureCanvasNbAgg'objecthasnoattribute'_last_renderer' |
If I run UAT 1 and then skip down to UAT 13, it runs but the spines and tick labels are flickering. |
If you resize it a couple times it eventually sorts it's self out. I think the underlying issue is related to it actually havingtwo renderers so half the time it ends up drawing the line on to a renderer that never had the rest of the artists drawn. The re-sizing causes enough thrashing that eventually things work out. Looking into this now. |
There are other problems such as the animation object not stopping after the figure is closed which pins a CPU.... |
I would bet that that problem is the same as the one recently reported for
|
fixes some issues (makes sure we always have a renderer), but somethingmuch worse is wrong underneath (the animation objects goes crazy andeats all of the CPU).
Apologies that this has become a bit stale. Rebasing this on top of master, I get: It would be nice to see this revived... |
…plotlib#4290. Everything seems to work ok except UAT4 doesn't close the old figure (just gets rid of the interactive widgets around it), and UAT13 has flickering at the edges of the axis (y ticks).
… compatibility with latest jupyter notebook).
Closing in lieu of#9240 |
Closes#4288