Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
BUG: Quiver must copy U, V, C args so they can't change before draw()#4250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
lib/matplotlib/tests/test_quiver.py Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
pep8 is complaining about one too few new lines here.
BUG : Quiver must copy U, V, C args so they can't change before draw()
tacaswell commentedMar 21, 2015
@efiring Is this worth back-porting to the color-overhaul branch? |
efiring commentedMar 21, 2015
Yes, I think it is worth backporting. I've never been 100% sure what procedure to use for this; is it OK to simply cherry-pick the commit to the appropriate branch locally, and then push to github? Is that the way you have been doing it? |
tacaswell commentedMar 21, 2015
That is what I have been doing on the premise that if I can merge someone elses PR tothis branch it's kosher to merge it to an other branch. I'll take care of moving this one over. |
BUG : Quiver must copy U, V, C args so they can't change before draw()
tacaswell commentedMar 21, 2015
back-ported as5852d83 |
efiring commentedMar 21, 2015
Thank you. |
For the same reason as Quiver inmatplotlib#4250.
The bug was revealed when a user was plotting to successive subplots inside a loop iterating through a numerical integration. U and V were references to objects that were updated inside the loop, but the figure was not drawn until the end. Therefore all panels showed the quiver of the last iteration.