Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: resizing a figure in webagg#4035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Tested, LGTM, 👍 |
| function mouse_event_fn(event) { | ||
| return fig.mouse_event(event, event['data']); | ||
| if (pass_mouse_events) | ||
| { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Style nit: we haven't been using braces if there is only one statement.
@blink1073 how do I submit a revision to the code? If I remove the brackets and push the new code to my fork on github will the pull request here get automatically synhronized? |
Yes, you can keep pushing changes to your |
Curly braces have been terminated. But an accidental commit was added! |
088bedb to0a245acCompareWell, just did my first rebase. And forced a push into github repository. There should be only a single commit. :) |
Looks good@eyurtsev. You didn't necessarily have to rebase for just one extra commit. |
👍 LGTM |
FIX : resizing a figure in webagg
also, improved functionality with a net removal of code! |
FIX : resizing a figure in webagg
back ported as7468be2 |
@blink1073 it was time to learn :) |
Resizing in webagg doesn't work because the figure grabs mouse events (#3338).
This is an iteration over a previous pull request (#3341), including the minimal changes required to fix the problem.
I don't think that the debouncing is necessary anymore, so I removed it. I tested this with both a static plot and animations.
This addresses 90% of the problem.
Resizing issues will reappear if working with multiple figures on the same page.
Refactoring would be necessary probably to introduce some "resizing manager" that will prevent mouse events from being passed to all figures while any figure is being resized.