NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.4k

[WIP] Quad mesh extent #3095#4017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

tacaswell wants to merge2 commits intomatplotlib:v1.4.xfromtacaswell:quad_mesh_extent-#3095

Closed

[WIP] Quad mesh extent #3095#4017

tacaswell wants to merge2 commits intomatplotlib:v1.4.xfromtacaswell:quad_mesh_extent-#3095

Conversation

Copy link

Member

tacaswell commentedJan 20, 2015

I don't think this currently deals with the offsets properly (as it seems that all of the collections will just repeat if the number of paths or the number of offsets (or number of transforms) don't match).

The other option is to just haveQuadMesh return a null bounding box for it's size and exclude it from the tight bounding box computation.

@mdboom Am I at least headed the right direction?

tacaswell added2 commits

January 19, 2015 22:15

BUG : provide get_window_extent for QuadMesh

f884001

fixesmatplotlib#3095Without a `get_window_extent` method defined, it was falling backto the `Collection` version which in turn called (eventually)`covert_mesh_to_paths`, which resulted in a >5x blow up in thememory usage.

MNT : make sure the correct ignore behavior is used

349d6da

tacaswell added the status: needs review label

Jan 20, 2015

tacaswell added this to thev1.4.3 milestone

Jan 20, 2015

Copy link

MemberAuthor

tacaswell commentedJan 20, 2015

Addresses#3095

Copy link

MemberAuthor

tacaswell commentedJan 27, 2015

@efiring Can you also take a look at this one? I think this and#4023 are the two major code-blockers for 1.4.3.

Copy link

Member

efiring commentedJan 27, 2015

Tom, I've looked at it a couple times already without understanding it. I think I will need a chunk of time, and it's unlikely I will be able to spare that during the next couple of days, at least. I know, the end-of-the-month target is fast approaching...

Copy link

Member

pelson commentedJan 27, 2015

@tacaswell - a few months back we updated the add_collection method (

matplotlib/lib/matplotlib/axes/_base.py

Line 1477 inbb19e7c

self.update_datalim(collection.get_datalim(self.transData))

) to update the data lim based on a collection. Where previously this was done by the axes, the responsibility of identifying the data limits was moved to the Collection itself. It might be possible to hook into this calculation rather than having to re-compute the offsets etc.

Copy link

Member

efiring commentedJan 27, 2015

@pelson, I think the change you mention is precisely the problem being addressed here. See#3095.

pelson mentioned this pull request

Jan 28, 2015

Fixed large pcolormesh rendering with bbox_inches='tight'.#4045

Merged

Copy link

Member

pelson commentedJan 28, 2015

Thanks to@tacaswell &@efiring for the hint. The linked commit (88b722f) was the key. Essentially, I believe all is needed is a get_datalim method on the quadmesh object.#4045 fixes.