Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Allow interrupts to be delivered once Python is fixed.#4006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
@mdehoon Who else knows this code well enough to review it? |
and should this be back-ported to 1.4.x? |
@tacaswell Few people have a good understanding of event loops, in particular people coming from a scripting background. This PR is not a major change, so I think getting a review is not critical. I would suggest to wait until Python itself is fixed (because without that, this PR doesn't add any functionality anyway), and after that apply the PR and let some users test it. This PR does not need to be back-ported to 1.4.x. |
I have uploaded a patch for Python; see issue 23237 at |
Is there harm in merging this before python is fixed? |
This can be merged before Python is fixed, so it's OK to merge it now. This pull request also fixes issue#3654 . |
BUG : Allow interrupts to be delivered once Python is fixed + path fixes
This is related to issue#3991. Until now the MacOSX backend did not deliver interrupts while the event loop is running as Python itself would ignore those interrupts anyway. This PR allows interrupts to be delivered once Python is fixed.