NotificationsYou must be signed in to change notification settings
Fork8.1k
Star22.1k

Final decxx corrections to PR #3723#3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

mdboom merged 1 commit intomatplotlib:masterfromianthomas23:final_decxx_corrections

Nov 3, 2014

Merged

Final decxx corrections to PR #3723#3744

mdboom merged 1 commit intomatplotlib:masterfromianthomas23:final_decxx_corrections

Nov 3, 2014

Conversation

Copy link

Member

ianthomas23 commentedOct 31, 2014

Corrections to PR#3723, the removal of PyCXX from the _tri module. I've made the four requested changes. Using the new C++ array_view classes has improved the code, but the changes pervade all three of the C++ files making it hard to review. However, all tri tests pass, the examples produce the same output, and there are no memory leaks in either.

tacaswell added the status: needs review label

Oct 31, 2014

tacaswell added this to thev1.5.x milestone

Oct 31, 2014

tacaswell assignedmdboom

Oct 31, 2014

Copy link

Member

mdboom commentedNov 3, 2014

Very nice. I'm not sure why Travis-CI hasn't come along and tested this yet... I'll look into that.

Copy link

Member

mdboom commentedNov 3, 2014

@tacaswell: Any thoughts about why Travis-CI hasn't picked this up, and how to force it? I don't know if I've seen this happen before.

Copy link

Member

jenshnielsen commentedNov 3, 2014

@mdboom I have seen that happen before. I guess it happens because the webhook somehow doesn't reach Travis. The only way I know is to push against the branch again. The Jenkins plugin that we use for other projects has the ability to trigger on strings in the comments but Travis don't seem to allow this.