Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
fix for figure resizing in webagg#3341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This looks good. Thanks@eyurtsev. It'd be good to pull the functionality out of the main figure function and into its own function. Also, when resizing animations, the animation frames are still updating the grayed out box - truthfully though, I'm not sure I'm 100% supportive of the graying out of the figure - that isn't the behaviour I get with other backends, and sometimes you want to resize the figure based on what the figure looks like (for instance, you might want to resize to optimize axes space for equal-aspect plots). Also, did you test this with the nbagg backend? |
Graying out the figure: I agree I'd be happier if this could look exactly like the other On my machine the plot wasn't updating quickly enough to render in real animations: nbagg: The pull request is missing a var in front of the variable ctx. Without this correction it fails in nbagg! (I wonder why it works with webagg) I can submit a new pull request either implementing the issue with the variable or else entirely removing the graying out behavior. (But it'll be only in a few weeks.) I can also factor out the functionality out of the figure, but that can take sometime since I'll need to study the code more carefully. Let me know what you'd prefer. |
@eyurtsev Any interest in reviving this PR? |
How about we limit the number of redraws when resizing - something like 1.5Hz would be a reasonable rate when resizing. |
@tacaswell sorry just saw your message. i need to fix my github email preferences... |
I actually removed the debouncing in the new PR. It seems to be unnecessary now that the mouse events are ignored while resizing. |
@tacaswell thanks for the information! I have only made a few PRs to date, and never revised one, so I wasn't sure how to do it. Anyway, I applied the changes on top of the running master, so less changes to merge now. :) |
This is a fix for this issue:#3338
Currently, resizing does not work well in the webagg backend because mouse events are not ignored during the resize, which makes it both difficult and slow to do.
The code below ignores mouse events while resizing, but the fix is only for the figure in question. (So resizing figure 1 over figure 2 won't stop figure 2 from responding to mouse events.)
I also included some cosmetic changes: while resizing the figure, the figure is not rendered continuously but is replaced by a light gray box. This makes the resizing look a lot smoother in my opinion.
I have (very) little experience with javascript/html/css, so I wasn't sure where to place the CSS code for the "boxme" class. (It's directly in the javascript below, which probably isn't the best idea.)