Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Add __repr__ to Formatter and Locator classes#30876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
DavidAGInnovation wants to merge2 commits intomatplotlib:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Add __repr__ to Formatter and Locator classes#30876
DavidAGInnovation wants to merge2 commits intomatplotlib:mainfromDavidAGInnovation:feature/add-repr-to-ticker-classes
+1,606 −983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Added informative __repr__ methods to all Formatter and Locatorsubclasses in matplotlib.ticker, so that eval(repr(obj)) returnsan equivalent object.Formatters:- NullFormatter- FixedFormatter- FuncFormatter- FormatStrFormatter- StrMethodFormatter- LogFormatter- LogitFormatter- EngFormatter- PercentFormatterLocators:- NullLocator- FixedLocator- IndexLocator- LinearLocator- MultipleLocator- MaxNLocator- AutoLocator- AutoMinorLocator- LogLocator- SymmetricalLogLocator- AsinhLocator- LogitLocatorAlso fixed two pytest.mark.parametrize deprecation warnings thatwere using zip iterators instead of lists.
Member
story645 commentedDec 17, 2025
Hi@DavidAGInnovation. Thanks for the PR. Can you please strip out the formatting changes because they're making it difficult to review your implementation. |
The 10 second timeout was too short for Windows CI, causingintermittent failures. Increased to 30 seconds to providesufficient headroom on slow CI machines.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes#21898
Added informative
__repr__methods to all Formatter and Locator subclasses inmatplotlib.ticker, so thateval(repr(obj))returns an equivalent object.Formatters (9 classes):
NullFormatterFixedFormatterFuncFormatterFormatStrFormatterStrMethodFormatterLogFormatterLogitFormatterEngFormatterPercentFormatterLocators (12 classes):
NullLocatorFixedLocatorIndexLocatorLinearLocatorMultipleLocatorMaxNLocatorAutoLocatorAutoMinorLocatorLogLocatorSymmetricalLogLocatorAsinhLocatorLogitLocatorAdditional fixes:
pytest.mark.parametrizedeprecation warnings (PytestRemovedIn10Warning) that were usingzipiterators instead of lists.Testing
test_ticker.pypass__repr__methodsExample outputs: