Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Revampdraw_path_collection() API.#30811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
r3kste wants to merge1 commit intomatplotlib:mainChoose a base branch fromr3kste:draw_path_collection_refactor
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Co-authored-by: Pranav <kingprawn5000@gmail.com>Co-authored-by: AdwaithBatchu <adwaithbatchu@gmail.com>Co-authored-by: Sreekanth-M8 <kmsreekanthsai@gmail.com>Co-authored-by: Sujal Kumar <sujaljayantkumar06@gmail.com>
195e00e toa1ba476CompareMember
timhoffm commentedDec 7, 2025
Thanks for the PR. I‘d like to hold this off until#30777 is in. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
closes#30547
This PR enhances the API of
draw_path_collection()for long term maintainability.Summary of Changes
Introduces the new
VectorizedGraphicsContextBaseclass, which is similar toGraphicsContextBase, but each attribute is vectorized. This serves as the dataclass through which all parameters are passed todraw_path_collection().Updated signature of
draw_path_collection()by making the parameters optional in order to support both the following:gcand all parameters presentvgcand none of the optional parametersUpdated signature of
_iter_collection()to takevgcinstead ofgcand added logic to cycle through all attributes.Changed
draw()inCollectionto use the newdraw_path_collection()API along withtemporary fallback for third-party backends that use the old signature.Why is this change required?
It would become much simpler to add / vectorize new attributes in collections, without completely breaking third party backends. For example, it would greatly simplify#27937, that aims to vectorize the
hatchattribute.To-do
PR checklist