Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
fix: uses scatter markers with facecolor = 'none'#30671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
cairibep wants to merge1 commit intomatplotlib:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Member
QuLogic commentedOct 23, 2025
There are linting errors, but more importantly, it appears you've removed very large chunks of existing support, which breaks the tests, and would not be wanted. |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fix the bug described in#24404, in which the
scatterfunction did not respect thefacecolors='none'option, resulting in filled markers even when the user only wanted an outline. Since there are logs reporting the possibility that thecparameter inscatter()might fail to overridefacecolor, this implementation accounts for this possibility.Why is this change necessary?
The
facecolors='none'option should produce hollow (unfilled) markers, but the current behavior ignored this setting, filling the markers with the default color.What problem does it solve? Allows
plt.scatter(..., facecolors='none')to correctly draw empty markers—that is, with only the outline visible, as expected and as per the documentation.What is the reason for this implementation?
The implementation adjusts the internal handling of
facecolorsinPathCollection, ensuring that the valuenoneis interpreted correctly and the fill is omitted.Minimal Example
Old output:
Result with modification:
Operating system
windows
Matplotlib Version
latest
Python version
3.11