Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Grammar corrections in User guide FAQ#30665
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
- Use "its" (the possessive form of "it") instead of "it's" (the contraction of "it is").- Change plurality of verb to match compound subject joined by "or". The verb should agree with the part of the subject closest to it. Seehttps://editorsmanual.com/articles/compound-subject-singular-or-plural/.
doc/users/faq.rst Outdated
| We've decided not to include this as a figure method because this is only one | ||
| way of defining empty, and checking the above is only rarely necessary. | ||
| Usually the user or program handling the figureknow ifthey have added | ||
| Usually the user or program handling the figureknows ifit has added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Usually the user or program handling the figure knows ifit has added | |
| Usually the user(or program) handling the figure knows ifthey (it) has added |
I think the issue here is that user and program get different pronouns and casting to passive voice won't work b/c the ownership is what's important.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If we parenthesize "or program" and "it", we should change "has" to "have" in order to match the pronoun "they". (Sorry I don't know how to modify a suggested change directly.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Couldn't we simply write
| Usually the user or program handling the figureknows ifit has added | |
| Usually the user or program handling the figureknow ifthey have added |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It's a bad combination of count/program/conjugation agreement.
A user knows what changes they have made and a program knows what changes it has made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ask an LLM. They are good at this. 😃 - I leave this to whoever cares because there’s not the one correct answer, and I as non-native speaker are not particularly qualified to judge.
Restructure sentence to avoid subject/pronoun/verb disagreement.
| way of defining empty, and checking the above is only rarely necessary. | ||
| Usually the user or program handlingthe figureknow if they have added | ||
| something tothefigure. | ||
| Whether or not something has been added tothe figureis usually defined |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| Whether or not something has been added to the figure is usually defined | |
| Whether or not something has been added to the figure is usually defined |
PR summary
Minor grammar corrections in existing documentation.
PR checklist