Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MNT: add dummy issue message to PR greeting workflow#30635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
rcomer wants to merge1 commit intomatplotlib:main
base:main
Choose a base branch
Loading
fromrcomer:pr-greeting-name

Conversation

@rcomer
Copy link
Member

PR summary

Replacement for#30633, since if you force push when the PR is closed, you can't re-open.

Hopefully fixes the PR greeting action, which currently fails likethis. I had read the error message wrong 🤦‍♀️, and the${name} variable in the code was actuallyissue_message in our case. Here is an example in my fork of the workflow now running:rcomer#5 (comment). I also tried settingissue_message to an empty string,but that didn't work.

PR checklist

@rcomer
Copy link
MemberAuthor

I am somewhat suspicious that it thinks that was my first PR in my fork. So opened a couple more and it commented on those too. I note that in the action's own repo the dependabot PRs are getting flagged for the new contributor messageactions/first-interaction#363 (comment)

Something seems off to me.

@rcomer
Copy link
MemberAuthor

The problem that this PR was trying to fix is now tracked atactions/first-interaction#365. The problem of every PR being identified as a new contribution is now tracked atactions/first-interaction#369. So I think it's better to wait and see what happens over there.

@heinrich5991
Copy link
Contributor

Replacement for#30633, since if you force push when the PR is closed, you can't re-open.

Off-topic: You can reopen a closed pull request by first force-pushing the expected commit hash, reopening and then force-pushing the wanted commit hash again:https://gist.github.com/robertpainsi/2c42c15f1ce6dab03a0675348edd4e2c.

rcomer reacted with thumbs up emojircomer reacted with eyes emoji

@ksunden
Copy link
Member

I have disabled the workflow (via Github Web UI) in the mean time until the problems are addressed (As it is not doing what we intend and is giving CI failures where they are not warranted)

rcomer reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rcomer@heinrich5991@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp