Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MNT: add dummy issue message to PR welcome#30633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
rcomer wants to merge1 commit intomatplotlib:mainfromrcomer:pr-greeting-name

Conversation

rcomer
Copy link
Member

@rcomerrcomer commentedOct 4, 2025
edited
Loading

PR summary

Hopefully fixes the PR greeting action, which currently fails likethis. It seems the job now requires an issue message, regardless of whether we run on issues.

PR checklist

@tacaswelltacaswell self-requested a reviewOctober 5, 2025 01:21
@tacaswell
Copy link
Member

Leaving my approval to self-merge when it works.

@rcomer
Copy link
MemberAuthor

I think, because we run onpull_request_target, we can’t prove it works till after it’s merged.

This event runs in the context of the base of the pull request, rather than in the context of the merge commit, as the pull_request event does. This prevents execution of unsafe code from the head of the pull request that could alter your repository or steal any secrets you use in your workflow.

https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target

@rcomer
Copy link
MemberAuthor

Huh. I tried making this the default branch on my fork and running there, but I still get the same error.
https://github.com/rcomer/matplotlib/actions/runs/18255963223/job/51977245701

I don’t know how to fix this.

@rcomerrcomer closed thisOct 5, 2025
@rcomerrcomer changed the titleMNT: add name to PR Welcome workflowMNT: add dummy issue message to PR welcomeOct 5, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswellAwaiting requested review from tacaswell

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@rcomer@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp