Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
New document page for logo usage guide#30631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
jeromefv wants to merge22 commits intomatplotlib:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
+1,039 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
This makes explicit calls to `autoscale_view()` or`_request_autoscale_view()` unnecessary.3D Axes have a special `auto_scale_xyz()`, also there's a mixture of`add_collection()` and `add_collection3d()`. This needs separate sorting. I've added a private value `autolim="_datalim_only"` to keep thebehavior for 3D Axes unchanged for now. That will be resolved by afollow-up PR. I believe it's getting too complicated if we fold thisinto the 2D change.
- use `color` kwarg instead of separate `add_color()`- remove `autolim=True` from `add_collection()` calls as that is thedefault anyway
@story645 Draft PR for reference! |
Thanks! Have you tried setting the background/custom CSS like it's sketched out here: .dark-mode-card.sd-card-body{background-color:rgb(33,37,41) } ..card:::card-body:dark-mode-card |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
PR summary
This is a new page for the About us section to cover logo usage guidelines for Matplotlib. It has links to the official NumFOCUS trademark guidelines as well as the gallery page to generate the logo. I've added a table with the official colors for the logo with swatches as well.
The new page has official references and guidelines for using the Matplotlib logo. Many others also have a page similar to this. It can be the authority on how to use the logo correctly and link to important references. This coversthe issue here for adding a new page.
This is a draft pull request since I'm not able to figure out how to have the SVG reflect dark and light modes accurately. I'm hoping to get support from others on either a technical solution to have the logos work in either light or dark mode, or some other way to show them.
PR checklist