Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove forced fallback from FT2Font::load_char#30627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@QuLogic
Copy link
Member

PR summary

The only thing that expected this to work is Type 3 fonts in the PDF backend, but only to avoid an error when loading a range of characters (not all of which would be used.) This would introduce an odd behaviour in thatload_char could never fail even if the glyph never existed. You would instead end up with thenull glyph from the last font.

As of#30512, Type 3 fonts useload_glyph instead ofload_char, with a glyph that we know exists (because it's from the limited subset character map we've created), or 0 for the null glyph. Thus no fallback is needed, and we can instead warn if not found, as the code seems to have originally intended.

PR checklist

@QuLogicQuLogic added this to thev3.11.0 milestoneOct 3, 2025
@github-project-automationgithub-project-automationbot moved this toWaiting for other PR inFont and text overhaulOct 3, 2025
@QuLogicQuLogic moved this fromWaiting for other PR toReady for Review inFont and text overhaulOct 3, 2025
The only thing that expected this to work is Type 3 fonts in the PDFbackend, but only to avoid an error when loading a range of characters(not all of which would be used.) This would introduce an odd behaviourin that `load_char` could never fail even if the glyph never existed.You would instead end up with the `null` glyph from the last font.
@tacaswelltacaswell merged commitad0b47a intomatplotlib:text-overhaulNov 6, 2025
41 of 42 checks passed
@github-project-automationgithub-project-automationbot moved this fromReady for Review toDone inFont and text overhaulNov 6, 2025
@QuLogicQuLogic deleted the no-force-fallback branchNovember 20, 2025 20:42
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tacaswelltacaswelltacaswell approved these changes

@ksundenksundenksunden approved these changes

Assignees

No one assigned

Projects

Status: Done

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@QuLogic@tacaswell@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp