Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Remove forced fallback from FT2Font::load_char#30627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
QuLogic wants to merge1 commit intomatplotlib:text-overhaulChoose a base branch
base:text-overhaul
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+5 −7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The only thing that expected this to work is Type 3 fonts in the PDFbackend, but only to avoid an error when loading a range of characters(not all of which would be used.) This would introduce an odd behaviourin that `load_char` could never fail even if the glyph never existed.You would instead end up with the `null` glyph from the last font.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
The only thing that expected this to work is Type 3 fonts in the PDF backend, but only to avoid an error when loading a range of characters (not all of which would be used.) This would introduce an odd behaviour in that
load_charcould never fail even if the glyph never existed. You would instead end up with thenullglyph from the last font.As of#30512, Type 3 fonts use
load_glyphinstead ofload_char, with a glyph that we know exists (because it's from the limited subset character map we've created), or 0 for the null glyph. Thus no fallback is needed, and we can instead warn if not found, as the code seems to have originally intended.PR checklist