Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MNT: Make useblit a property in Widget classes#30605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

tacaswell
Copy link
Member

The goal is to skip trying to do anything with blitting when after the figure is closed a blitting-capable Canvas instance is swapped out for one that does not support blitting.

closes#30575 but in only a partial solution to the bigger issues with blitting and changing the canvas.

PR summary

Attempts to makeuseblit dynamic (and standardiizes it across all of the widget classes)

Not tested with MNE's case and have not sorted out a MWE to add a test.

PR checklist

The goal is to skip trying to do anything with blitting whenafter the figure is closed a blitting-capable Canvas instance isswapped out for one that does not support blitting.closesmatplotlib#30575 but in only a partial solution to the bigger issueswith blitting and changing the canvas.
@timhoffm
Copy link
Member

I think this PR is a bit dangerous by itself. It makes sure that the theuseblit status calculated dynamically and thus correctly. However we sometimes have state (background images) that are calculated based on theuseblit status and canvas at some point in time. If that is not correctly updated as well, we'll still get inconsistent behavior.

I've taken a more comprehensive approach in#30591, see in particular#30591 (comment)

@tacaswell
Copy link
MemberAuthor

Closing this in favor of#30591.

Sorry for the duplicate effort.

timhoffm reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Regression in widget behavior
2 participants
@tacaswell@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp