Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
converted assert into exception#3060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Merged
Changes from1 commit
Commits
Show all changes
36 commits Select commitHold shift + click to select a range
873e91d
converted assert into exception
montefrab297f41
Exception type modified according to @pelson comment
montefra187f584
removed assert in `draw_artist` and `redraw_in_frame`
montefra34c6a5f
most asserts modified to ValueError
montefra0c1f9f7
All asserts substituted by ValueError
montefra4cfa781
method name explicitly written in the message
montefraaba9d99
Most asserts changed to ValueErrors. Two changed to warning
montefra8fbb652
c* files done
montefra5a45046
assert removed
montefra33fdabe
Asserts removed. Side effect: function to check that the inputs have …
montefra67bdfea
Asserts removed throughout the files m*
montefra531004c
Asserts removed throughout the files r*
montefraeaca138
SyntaxError from Travis corrected
montefra9e4b911
assert removed from files s*
montefrad12fbb8
asserts removed from t* file. test and tri directories ignored
montefra7f80628
asserts removed from [u-z]* files
montefra4fc36c6
the only assert in a python public function removed
montefra617b622
Bug introduced while getting rid of the asserts fixed
montefra2cbb326
typo fixed (broke building documentation)
montefra20966e9
pep8 fixed. plot_day_summary2 removed (retained by error when rebasing)
montefra96c733e
PEP8 fixed
montefra140210f
PEP8 fixed - image.py
montefraa2abc7b
PEP 8 fixed - mlab.py
montefra25cec22
PEP 8 fixed - patches.py
montefra06aedf7
PEP8 fixed - path.py
montefra77da3b6
PEP8 fixed - sankey.py
montefra95ae2cd
PEP8 fixed - spines.py, table.py
montefrab167c0c
test adapted to code change (AssertionError -> ValueError)
montefraf9792a9
fixed according to #3060 comment
montefra850178e
Two bugs in assert -> exception transformation fixed
montefrac0ebd4f
Typo fixed
montefra6b6d2de
Bug in assert -> exception transformation fixed
montefra088542e
Typo fixed
montefra41bf6b5
Modified according to @tacaswell comments
montefra7ea5c1a
fixed pep8 Travis failure
montefrad6c3c32
python2.6 string formatting. style more uniform
montefraFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
PEP8 fixed - image.py
- Loading branch information
Uh oh!
There was an error while loading.Please reload this page.
commit140210fb73866d8fe5d9045c59a796d83e8e7940
There are no files selected for viewing
6 changes: 3 additions & 3 deletionslib/matplotlib/finance.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletionlib/matplotlib/image.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.