Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Merge main back into text-overhaul branch to fix CI#30579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 171 commits intomatplotlib:text-overhaulfromQuLogic:fix-text-overhaul-ci
Sep 19, 2025

Conversation

QuLogic
Copy link
Member

PR summary

This should fix macOS CI and the disjoint bases issue.

Also, add an ignore forGlyphIndexType in stubtest, which may or may not bean upstream problem, but is the simplest fix for now.

PR checklist

ksundenand others added30 commitsMay 9, 2025 12:23
…t-of-pr-30029-on-v3.10.3-docBackport PRmatplotlib#30029 on branch v3.10.3-doc (Update diagram in subplots_adjust documentation to clarify parameters)
…t-of-pr-30119-on-v3.10.3-docBackport PRmatplotlib#30119 on branch v3.10.3-doc (Add some types to _mathtext.py)
…t-of-pr-30118-on-v3.10.3-docBackport PRmatplotlib#30118 on branch v3.10.3-doc (CI: Skip jobs on forks)
…t-of-pr-30212-on-v3.10.3-docBackport PRmatplotlib#30212 on branch v3.10.3-doc ([Doc]: fix bug in release notes for matplotlib v3.5.0 and v3.7.0)
…t-of-pr-30244-on-v3.10.3-docBackport PRmatplotlib#30244 on branch v3.10.3-doc (DOC: Recommend to use bare Figure instances for saving to file)
…t-of-pr-30289-on-v3.10.3-docBackport PRmatplotlib#30289 on branch v3.10.3-doc (DOC: Fix build with pybind11 3)
It may be fundamentally nice not to have to create the figurethough pyplot to be able to use it in pyplot afterwards. You can now do```from matplotlib.figure import Figureimport matplotlib.pyplot as pltfig = Figure()fig.subplots().plot([1, 3, 2])plt.figure(fig)  # fig is now tracked in pyplotplt.show()```This also opens up the possibility to more dynamically trackand untrack figures in pyplot, which opens up the road tooptimized figure tracking in pyplot (matplotlib#29849)
When destroying a manager, replace the figure's canvas by afigure canvas base.
There in now machinery for all of the public API that takes arenderer is input to get it from the current canvas on the rootfigure.  Use that machinery instead.
Flush the wx canvas, not the base canvas that is installed on close.
This goes up the chain to the GUI classes that do not have this method.
This prevent the figures from growing on hi-dpi screens.
Co-authored-by: Ruth Comer <10599679+rcomer@users.noreply.github.com>
@github-actionsgithub-actionsbot added topic: canvas and figure manager Documentation: examplesfiles in galleries/examples Documentation: devdocsfiles in doc/devel Documentation: user guidefiles in galleries/users_explain or doc/users labelsSep 18, 2025
timhoffmand others added2 commitsSeptember 18, 2025 07:20
On some CI, the Qt backend seems to be picked, but something is confusedand it fails due to an invalid `DISPLAY` variable. But this test doesn'tneed an interactive backend, so don't use one.
@QuLogic
Copy link
MemberAuthor

May want to wait to also add in#30581 here.

anntzerand others added3 commitsSeptember 18, 2025 09:10
Copy-edit the "fonts in pdf and postscript" table.
TST: Force Agg backend in test_openin_any_paranoid
@QuLogic
Copy link
MemberAuthor

I redid the merge now that#30581 is in, and now somehow GitHub has decided to show all the commits frommain...

@QuLogic
Copy link
MemberAuthor

The last merge into thetext-overhaul branch was9766cbd, which came from2eccf17, so this PR should be equal to2eccf17...5cdd827 + the last commit.

@tacaswell
Copy link
Member

Some of the failures look real but one of them is the c-coverage filter issue that we have fixed at least twice...

Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Leave to@QuLogic discretion to fix the failing tests in this PR or to do it in a follow on.

@QuLogic
Copy link
MemberAuthor

QuLogic commentedSep 18, 2025
edited
Loading

Some of the failures look real but one of them is the c-coverage filter issue that we have fixed at least twice...

Ah, I think we have a specific cutout forubuntu-24.04, but it should also catchubuntu-22.04-arm as well. It has lcov 2:
https://github.com/matplotlib/matplotlib/actions/runs/17839138498/job/50723813450?pr=30579#step:5:876
(not sure whynon-arm is still 1.15 though).

Let me push that and see if it works.

@QuLogic
Copy link
MemberAuthor

This is actually affecting themain branch as well; I've opened#30586 to fix it there.

QuLogicand others added4 commitsSeptember 18, 2025 17:58
Since earlier today, the `ubuntu-22.04-arm` image has actually beenUbuntu 24.04. Instead of working out how to fix that, switch to thenewer image explicitly.
This may be an upstream bug [1], but until that is determined, ignorethe error to get CI working.[1]python/mypy#19877
@QuLogic
Copy link
MemberAuthor

Since everything is passing now, I'll merge, as normally I've been doingmain-to-text-overhaul merges without PRs.

@QuLogicQuLogic merged commit0da372b intomatplotlib:text-overhaulSep 19, 2025
41 of 42 checks passed
@QuLogicQuLogic deleted the fix-text-overhaul-ci branchSeptember 19, 2025 05:18
@github-project-automationgithub-project-automationbot moved this toWaiting for other PR inFont and text overhaulSep 19, 2025
@QuLogicQuLogic moved this fromWaiting for other PR toDone inFont and text overhaulSep 19, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Projects
Status: Done
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

23 participants
@QuLogic@tacaswell@ksunden@timhoffm@rcomer@jklymak@story645@itsmeamitesh01@Logan-Pageler@star1327p@dstansby@anntzer@trygvrad@ianthomas23@brchristian@geofft@MengAiDev@jonathimer@AasmaGupta@Aaratrika-Shelly@scottshambaugh@LangQi99@mx-moth

[8]ページ先頭

©2009-2025 Movatter.jp