Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Add os.PathLike support to FT2Font constructor, and FontManager#30573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
timhoffm approved these changesSep 17, 2025
Since we pass the filename to `io.open`, we can accept everything itcan.Also, fix the return value of `FT2Font.fname`, which could be `bytes` ifthat was initially provided.
| withpytest.raises(FileNotFoundError): | ||
| get_font(bytes(tmp_path/'non-existent-font-name.ttf')) | ||
| # Not really public, but get_font doesn't expose non-filename constructor. |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
note to future reviewers, this was removed as redundent with other test
tacaswell approved these changesSep 25, 2025
1b3ba17 intomatplotlib:text-overhaul 37 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
Since we pass the filename to
io.open, we can accept everything it can.Also, fix the return value of
FT2Font.fname, which could bebytesif that was initially provided.I extracted this out of#30334 since it's independent
PR checklist