Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Fix stubtest with mypy 18#30558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Closesmatplotlib#30551 by disabling checks for disjoint bases. There may be other solutions like decorating Container and dviread.Text with @disjoint_base, however I've not yet fully understood whether that'd be technically correct. We have survived without disjoint bases checks so far, so at least a a quick fix this should good enough.
QuLogic approved these changesSep 15, 2025
Going to merge over the system dependency installation failure on osx13 . |
88fab21 intomatplotlib:main 55 of 57 checks passed
Uh oh!
There was an error while loading.Please reload this page.
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestSep 16, 2025
timhoffm added a commit that referenced this pull requestSep 16, 2025
…558-on-v3.10.xBackport PR#30558 on branch v3.10.x (Fix stubtest with mypy 18)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#30551 by disabling checks for disjoint bases. There may be other
solutions like decorating Container and dviread.Text with
@disjoint_base, however I've not yet fully understood whether that'd be
technically correct. We have survived without disjoint bases checks so
far, so at least as a quick fix this should good enough.