NotificationsYou must be signed in to change notification settings
Fork8.1k
Star21.8k

Update Colorizer/ColorizingArtist to work with MultiNorm#30511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

trygvrad wants to merge2 commits intomatplotlib:main

base:main

Choose a base branch

fromtrygvrad:colorizer-multinorm

Open

Update Colorizer/ColorizingArtist to work with MultiNorm#30511

trygvrad wants to merge2 commits intomatplotlib:mainfromtrygvrad:colorizer-multinorm

+478 −76

Conversation

Copy link

Contributor

trygvrad commentedSep 3, 2025•
edited
Loading

EDIT: closes#30511

This PR continues the work of#28658 and#28454,#29876, aiming toclose#14168. (Feature request: Bivariate colormapping)

This PR allows Colorizer and ColorizingArtist to work withMultiNorm andBivarColormap andMultivarColormap

i.e. this PR will allow:

importmatplotlib.pyplotaspltimportnumpyasnpimportmatplotlibasmpla=np.arange(12).reshape(3,4)b=np.arange(12).reshape(4,3).Tnorm=mpl.colors.Normalize(vmin=0,vmax=11)col=mpl.colorizer.Colorizer(cmap='BiOrangeBlue',norm=[norm,norm])plt.imshow(col.to_rgba((a,b)))

Features not included in this PR:

Exposes the functionality provided by MultiNorm together with BivarColormap and MultivarColormap to the plotting functionsaxes.imshow(...),axes.pcolor(...), andaxes.pcolormesh(...)`
fig.colorbar() equivalents for BivarColormap and MultivarColormap
Examples in the docs

PR checklist

new and changed code istested

github-actionsbot added the topic: color/color & colormaps label

Sep 3, 2025

trygvrad force-pushed thecolorizer-multinorm branch from77bc51a to9044189Compare

September 3, 2025 17:20

QuLogic added this toBivariate and Multivariate Colormapping

Sep 3, 2025

QuLogic reviewed

Sep 4, 2025

View reviewed changes

lib/matplotlib/cbook.py OutdatedShow resolvedHide resolved

lib/matplotlib/colorizer.py OutdatedShow resolvedHide resolved

lib/matplotlib/tests/test_colors.py OutdatedShow resolvedHide resolved

lib/matplotlib/colorizer.py OutdatedShow resolvedHide resolved

github-actionsbot added the status: needs rebase label

Sep 4, 2025

trygvrad force-pushed thecolorizer-multinorm branch from9b9aaf3 to525314eCompare

September 4, 2025 23:35

Copy link

ContributorAuthor

trygvrad commentedSep 4, 2025

Thank you for the feedback@QuLogic and apologies for my sloppy mistakes :)

Update Colorizer/ColorizingArtist to work with MultiNorm

23fb63c

improved testing for colorizer+multinormApply suggestions from code reviewCo-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>updates based on feedback from@QuLogic

trygvrad force-pushed thecolorizer-multinorm branch from525314e to23fb63cCompare

September 8, 2025 07:20

github-actionsbot removed the status: needs rebase label

Sep 8, 2025

trygvrad moved this toIn Progress inBivariate and Multivariate Colormapping

Sep 8, 2025

This was referencedSep 8, 2025

Preparations for multivariate plotting#29877

Closed

Imshow, pcolor and pcolormesh with Bivariate and Multivariate colormaps#30526

Open

QuLogic reviewed

Sep 9, 2025

View reviewed changes

lib/matplotlib/colorizer.py OutdatedShow resolvedHide resolved

lib/matplotlib/tests/test_colors.py OutdatedShow resolvedHide resolved

lib/matplotlib/colorizer.py OutdatedShow resolvedHide resolved

Updates based on feedback from@QuLogic

d5c43e0

trygvrad force-pushed thecolorizer-multinorm branch fromeb37db8 tod5c43e0Compare

September 11, 2025 07:52

QuLogic approved these changes

Sep 11, 2025

View reviewed changes

Copy link

Member

QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

As I mentioned on the call, I think this looks okay from a low-level point-of-view, but I am at this point uncertain as to the high-level status. I hope someone more familiar with the current state can confirm.

PS,@trygvrad if you have some time to pop in to the call, it would be good to just re-iterate the current state succinctly, as I'm not sure everyone is up-to-speed right now.

trygvrad mentioned this pull request

Sep 24, 2025

Multivar imshow#30597

Open

2 tasks

story645 reviewed

Oct 10, 2025

View reviewed changes

Copy link

Member

story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry it took so long to get to this.

lib/matplotlib/colorizer.py

		ifnormand (xx.max()>1orxx.min()<0):
		raiseValueError("Floating point image RGB values "
		"must be in the 0..1 range.")
		"must be in the 0..1 range")

Copy link

Member

story645Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	"must be in the0..1 range")
	"must be in the[0,1] range")

teenyist nit but I find interval notation clearer

lib/matplotlib/colorizer.py

		"Passing a Normalize instance simultaneously with "
		"vmin/vmax is not supported. Please pass vmin/vmax "
		"directly to the norm when creating it.")
		"directly to the norm when creating it")

Copy link

Member

story645Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	"directlyto the norm when creating it")
	"as argumentsto the norm object when creating it")

I think more explicit is a bit clearer here

lib/matplotlib/colorizer.py

Comment on lines +254 to +259

		ifself.norm.n_components==1:
		ifvmaxisNone:
		try:
		vmin,vmax=vmin
		except (TypeError,ValueError):
		pass

Copy link

Member

story645Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just checking, this is for backwards compatibility with the current behavior, but doesn't broadcast, right?

lib/matplotlib/colorizer.py

		ifisinstance(self.cmap,colors.BivarColormap):
		n_s= (self.cmap.N,self.cmap.M)
		else:# colors.MultivarColormap
		n_s= [part.Nforpartinself.cmap]

Copy link

Member

story645Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	n_s= [part.Nforpartinself.cmap]
	n_s= [part.Nforpartinself.cmap]

does this also work for BivarColormap?

lib/matplotlib/colorizer.py

		scale_cls=_api.check_getitem(scale._scale_mapping,norm=norm)
		return_auto_norm_from_scale(scale_cls)()
		returnnorm
		else:# n_components > 1

Copy link

Member

story645Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	else:#n_components > 1
	elifn_components>1:

somebody could do something silly and enter n_components = 0

lib/matplotlib/colorizer.py

Comment on lines +899 to +902

		elifn_components==2:
		raiseValueError("Invalid data entry for multivariate data. The data"
		" must contain complex numbers, or have a first dimension 2,"
		" or be of a dtype with 2 fields")

Copy link

Member

story645Oct 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm not following what 2 components means in this context

Labels

topic: color/color & colormaps

3 participants

Movatterモバイル変換

Uh oh!

Update Colorizer/ColorizingArtist to work with MultiNorm#30511

Are you sure you want to change the base?

Update Colorizer/ColorizingArtist to work with MultiNorm#30511

Conversation

trygvrad commentedSep 3, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

PR checklist

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

trygvrad commentedSep 4, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QuLogic left a comment

Choose a reason for hiding this comment

Uh oh!

story645 left a comment

Choose a reason for hiding this comment

Uh oh!

story645Sep 18, 2025

Choose a reason for hiding this comment

Uh oh!

story645Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

story645Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

story645Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

story645Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

story645Oct 10, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

trygvrad commentedSep 3, 2025•
edited
Loading