Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Use pathlib in texmanager.#30431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromanntzer:tp
Aug 15, 2025
Merged

Use pathlib in texmanager.#30431

QuLogic merged 1 commit intomatplotlib:mainfromanntzer:tp
Aug 15, 2025

Conversation

@anntzer
Copy link
Contributor

Only a few changes are needed. Note that make_png returns an absolute path so path joining is not even needed here.

Also drop an unrelated but outdated comment re: background handling,
which is obsolete since 8940c66 (look forif hack: ...).

PR summary

PR checklist

Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Optional comments

Only a few changes are needed.  Note that make_png returns an absolutepath so path joining is not even needed here.Also restore the recently incorrectly removed usage of dpi in generatingthe png filename.Also drop an unrelated but outdated comment re: background handling,which is obsolete since 8940c66 (look for `if hack: ...`).
@anntzer
Copy link
ContributorAuthor

I just realized that in#30426 I accidentally and wrongly removed the dpi arg when generating the png filename (athttps://github.com/matplotlib/matplotlib/pull/30426/files#diff-6a0383194825a76389747fc0b369645f844ddc7fc7f30b300e4413fe40dc4b17L314); I fixed that in this commit as well so this should also be backported to 3.10.6, hence the milestoning (or I can make a separate commit with just that fix, if we want to be really granular...).

@QuLogicQuLogic merged commit1c3e043 intomatplotlib:mainAug 15, 2025
40 checks passed
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.10.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 1c3e0438cb890fe12e91c73b3782cae3b87060a5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #30431: Use pathlib in texmanager.'
  1. Push to a named branch:
git push YOURFORK v3.10.x:auto-backport-of-pr-30431-on-v3.10.x
  1. Create a PR against branch v3.10.x, I would have named this PR:

"Backport PR#30431 on branch v3.10.x (Use pathlib in texmanager.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@QuLogic
Copy link
Member

Hmm, maybe only backport the fix?

@anntzeranntzer deleted the tp branchAugust 16, 2025 09:16
anntzer added a commit to anntzer/matplotlib that referenced this pull requestAug 16, 2025
…_dvi & make_png.Includes an extra fix from PRmatplotlib#30431: Don't drop dpi in png filenamegeneration.
@anntzer
Copy link
ContributorAuthor

OK, I opened#30434 for the backport with the extra fix. (If you want to first merge the automatic PR and add an extra fix commit on top of that, feel free to do so instead, I don't mind either way.)

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@QuLogicQuLogicQuLogic approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

v3.10.6

Development

Successfully merging this pull request may close these issues.

4 participants

@anntzer@QuLogic@timhoffm@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp