Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
Use pathlib in texmanager.#30431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
timhoffm left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Optional comments
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Only a few changes are needed. Note that make_png returns an absolutepath so path joining is not even needed here.Also restore the recently incorrectly removed usage of dpi in generatingthe png filename.Also drop an unrelated but outdated comment re: background handling,which is obsolete since 8940c66 (look for `if hack: ...`).
anntzer commentedAug 15, 2025
I just realized that in#30426 I accidentally and wrongly removed the dpi arg when generating the png filename (athttps://github.com/matplotlib/matplotlib/pull/30426/files#diff-6a0383194825a76389747fc0b369645f844ddc7fc7f30b300e4413fe40dc4b17L314); I fixed that in this commit as well so this should also be backported to 3.10.6, hence the milestoning (or I can make a separate commit with just that fix, if we want to be really granular...). |
1c3e043 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free tosuggest an improvement. |
QuLogic commentedAug 15, 2025
Hmm, maybe only backport the fix? |
…_dvi & make_png.Includes an extra fix from PRmatplotlib#30431: Don't drop dpi in png filenamegeneration.
anntzer commentedAug 16, 2025
OK, I opened#30434 for the backport with the extra fix. (If you want to first merge the automatic PR and add an extra fix commit on top of that, feel free to do so instead, I don't mind either way.) |
Only a few changes are needed. Note that make_png returns an absolute path so path joining is not even needed here.
Also drop an unrelated but outdated comment re: background handling,
which is obsolete since 8940c66 (look for
if hack: ...).PR summary
PR checklist