Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

{Check,Radio}Buttons: Improve docs of label_props#30412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@doronbehar
Copy link
Contributor

PR summary

Mostly addresses#30393. One may argue the API is still inconsistent, but at least it is documented now.

PR checklist

@doronbehardoronbeharforce-pushed the_Buttons--label_props.doc branch from95c4dda to5493009CompareAugust 12, 2025 23:38
Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks - this looks good now. There's a couple of links that need fixing though, I think (but haven't tested) that my inline suggestions to reference the classes instead of__init__ should work.

@doronbehardoronbeharforce-pushed the_Buttons--label_props.doc branch from5493009 tof7376b1CompareAugust 13, 2025 10:34
@dstansbydstansby added this to thev3.10.6 milestoneAug 13, 2025
@ksunden
Copy link
Member

Not sure if we want to roll it into here or do it separately, but looks like the type hint forlabel_props should also be updated.

label_props:dict[str,Any]|Sequence[dict[str,Any]]|None= ...,

That type hint was based on reading the docstring, but it is clear from the code thatSequence/list was not actually a viable input to this parameter. (Namely, there is a check_is_instance for dict/None)

That was the one change that flagged to me as "oh, this is actually changing the documented type, we should be sure of that" and upon looking, I agree with the new version, just looking to keep the type hints in sync if we can.

@doronbehar
Copy link
ContributorAuthor

Thanks for noticing this@ksunden. I think it is appropriate to fix this in this PR too - type hints are sort of a documentation. Pushed a fix.

@doronbehardoronbeharforce-pushed the_Buttons--label_props.doc branch from0ef0da4 to2e10b79CompareAugust 14, 2025 22:01
@dstansbydstansby merged commit443ec06 intomatplotlib:mainAug 20, 2025
38 of 40 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestAug 20, 2025
timhoffm added a commit that referenced this pull requestAug 20, 2025
…412-on-v3.10.xBackport PR#30412 on branch v3.10.x ({Check,Radio}Buttons: Improve docs of label_props)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@QuLogicQuLogicQuLogic approved these changes

@dstansbydstansbydstansby approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

v3.10.6

Development

Successfully merging this pull request may close these issues.

4 participants

@doronbehar@ksunden@QuLogic@dstansby

[8]ページ先頭

©2009-2025 Movatter.jp