Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
{Check,Radio}Buttons: Improve docs of label_props#30412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
95c4dda to5493009Compare
dstansby left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks - this looks good now. There's a couple of links that need fixing though, I think (but haven't tested) that my inline suggestions to reference the classes instead of__init__ should work.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
5493009 tof7376b1Compareksunden commentedAug 14, 2025
Not sure if we want to roll it into here or do it separately, but looks like the type hint for matplotlib/lib/matplotlib/widgets.pyi Line 211 in77a16b9
That type hint was based on reading the docstring, but it is clear from the code that That was the one change that flagged to me as "oh, this is actually changing the documented type, we should be sure of that" and upon looking, I agree with the new version, just looking to keep the type hints in sync if we can. |
doronbehar commentedAug 14, 2025
Thanks for noticing this@ksunden. I think it is appropriate to fix this in this PR too - type hints are sort of a documentation. Pushed a fix. |
d6073f1 to0ef0da4Compare0ef0da4 to2e10b79Compare443ec06 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…412-on-v3.10.xBackport PR#30412 on branch v3.10.x ({Check,Radio}Buttons: Improve docs of label_props)
PR summary
Mostly addresses#30393. One may argue the API is still inconsistent, but at least it is documented now.
PR checklist