Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add support for loading all fonts from collections#30334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
QuLogic wants to merge7 commits intomatplotlib:text-overhaul
base:text-overhaul
Choose a base branch
Loading
fromQuLogic:ttc-loading

Conversation

@QuLogic
Copy link
Member

@QuLogicQuLogic commentedJul 19, 2025•
edited
Loading

PR summary

This turned out to be more straightforward than I expected, but it will probably need a few API decisions to be fully complete.

From bottom to top of the API:

  1. FT2Font accepts aface_index parameter to specify which face to load in a collection, and a correspondingface_index property to check what's loaded.
  2. For backwards-compatibility,FontManager.findfont returns astr-like classFontPath (name up for debate) which has aface_index attribute and is accepted byget_font. If anyone uses them as strings though, it should act pretty much the same.

For example, now I can see all variants of Noto Sans CJK:

>>> import matplotlib.font_manager>>> for fe in matplotlib.font_manager.fontManager.ttflist:...     if fe.name.startswith('Noto Sans Mono CJK'):...         print(fe)...         FontEntry(fname='/usr/share/fonts/google-noto-sans-mono-cjk-vf-fonts/NotoSansMonoCJK-VF.ttc', index=0, name='Noto Sans Mono CJK JP', style='normal', variant='normal', weight=400, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-mono-cjk-vf-fonts/NotoSansMonoCJK-VF.ttc', index=1, name='Noto Sans Mono CJK KR', style='normal', variant='normal', weight=400, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-mono-cjk-vf-fonts/NotoSansMonoCJK-VF.ttc', index=2, name='Noto Sans Mono CJK SC', style='normal', variant='normal', weight=400, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-mono-cjk-vf-fonts/NotoSansMonoCJK-VF.ttc', index=3, name='Noto Sans Mono CJK TC', style='normal', variant='normal', weight=400, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-mono-cjk-vf-fonts/NotoSansMonoCJK-VF.ttc', index=4, name='Noto Sans Mono CJK HK', style='normal', variant='normal', weight=400, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-cjk-fonts/NotoSansCJK-Regular.ttc', index=5, name='Noto Sans Mono CJK JP', style='normal', variant='normal', weight=400, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-cjk-fonts/NotoSansCJK-Regular.ttc', index=6, name='Noto Sans Mono CJK KR', style='normal', variant='normal', weight=400, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-cjk-fonts/NotoSansCJK-Regular.ttc', index=7, name='Noto Sans Mono CJK SC', style='normal', variant='normal', weight=400, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-cjk-fonts/NotoSansCJK-Regular.ttc', index=8, name='Noto Sans Mono CJK TC', style='normal', variant='normal', weight=400, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-cjk-fonts/NotoSansCJK-Regular.ttc', index=9, name='Noto Sans Mono CJK HK', style='normal', variant='normal', weight=400, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-cjk-fonts/NotoSansCJK-Bold.ttc', index=5, name='Noto Sans Mono CJK JP', style='normal', variant='normal', weight=700, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-cjk-fonts/NotoSansCJK-Bold.ttc', index=6, name='Noto Sans Mono CJK KR', style='normal', variant='normal', weight=700, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-cjk-fonts/NotoSansCJK-Bold.ttc', index=7, name='Noto Sans Mono CJK SC', style='normal', variant='normal', weight=700, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-cjk-fonts/NotoSansCJK-Bold.ttc', index=8, name='Noto Sans Mono CJK TC', style='normal', variant='normal', weight=700, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/google-noto-sans-cjk-fonts/NotoSansCJK-Bold.ttc', index=9, name='Noto Sans Mono CJK HK', style='normal', variant='normal', weight=700, stretch='normal', size='scalable')

or all variants of WenQuanYi that we use for tests:

>>> for fe in matplotlib.font_manager.fontManager.ttflist:...     if fe.name.startswith('WenQuan'):...         print(fe)...         FontEntry(fname='/usr/share/fonts/wqy-zenhei-fonts/wqy-zenhei.ttc', index=0, name='WenQuanYi Zen Hei', style='normal', variant='normal', weight=500, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/wqy-zenhei-fonts/wqy-zenhei.ttc', index=1, name='WenQuanYi Zen Hei Mono', style='normal', variant='normal', weight=500, stretch='normal', size='scalable')FontEntry(fname='/usr/share/fonts/wqy-zenhei-fonts/wqy-zenhei.ttc', index=2, name='WenQuanYi Zen Hei Sharp', style='normal', variant='normal', weight=500, stretch='normal', size='scalable')

Fixes#3135

TODO

  1. Font subsetting in vector formats still hard-codes face index 0. This is mostly because it passes around filenames everywhere, so that will have to be changed to include the face index.
  2. As you can see above, there are two versions of Noto Sans CJK that are found: one for each weight and a variable font. We don't seem to correctly read any differentiating metadata for the variable font, so whether it or the separate Regular version gets picked is a bit up in the air, I think.

API questions

  1. Considering the typing is quite long withstr | bytes | Path, I wonder if we should change toos.PathLike?
  2. I originally started with the path-index tuple as an end goal, but after creating the backwards-compatibleFontPath, I'm thinking maybe that's redundant and we should just stick with theFontPath class only. Do we want to accept the tuple form as well, or should I drop it?
  3. Currently,FontPath is a subclass ofstr which allows using it as astr as one normally would. That was the minimum implementation needed, but we probably want to flesh that out a bit. At minimum, I think we should implement__eq__ and__hash__ so that you can use it as a dictionary key without clashing with an equivalentstr. But then do we want to add a deprecation warning when making those comparisons? And after thinking about it a bit more, would anamedtuple with__eq__ instead be a better choice?
  4. Do we want to figure out a way to group these somehow (in a way something likeAdd font.superfamily support with genre-aware resolution #30155)? Unfortunately, I think this is actually non-trivial. On Fedora for example, the Noto Sans package installs a fontconfig file that groups them and specifies which language corresponds to which font. It is likely not something embedded in the font that we can read ourselves, and we don't use fontconfig either.

PR checklist

@QuLogicQuLogic added this to thev3.11.0 milestoneJul 19, 2025
@QuLogicQuLogic added the status: needs comment/discussionneeds consensus on next step labelJul 19, 2025
@github-project-automationgithub-project-automationbot moved this toWaiting for other PR inFont and text overhaulJul 19, 2025
@QuLogicQuLogic moved this fromWaiting for other PR toReady for Review inFont and text overhaulJul 19, 2025
@QuLogic
Copy link
MemberAuthor

We had a discussion about this on the call earlier.

  • I originally started with the path-index tuple as an end goal, but after creating the backwards-compatibleFontPath, I'm thinking maybe that's redundant and we should just stick with theFontPath class only. Do we want to accept the tuple form as well, or should I drop it?

We'll drop the tuple for now, as it seems thestr-ish type should be fine.

  • Currently,FontPath is a subclass ofstr which allows using it as astr as one normally would. That was the minimum implementation needed, but we probably want to flesh that out a bit. At minimum, I think we should implement__eq__ and__hash__ so that you can use it as a dictionary key without clashing with an equivalentstr. But then do we want to add a deprecation warning when making those comparisons? And after thinking about it a bit more, would anamedtuple with__eq__ instead be a better choice?

We'll not deprecate anything for now, and see how this works out. SinceFontPath is fairly equivalent tostr, there likely won't be much in the way of breakage. For methods, we'll implement at least__eq__,__hash__ and__repr__.

  • Do we want to figure out a way to group these somehow

Will leave this for later, if necessary.

@QuLogicQuLogic marked this pull request as ready for reviewJuly 25, 2025 11:02
@QuLogicQuLogic removed the status: needs comment/discussionneeds consensus on next step labelJul 25, 2025
@QuLogic
Copy link
MemberAuthor

This should work almost everywhere now, I think. The only thing that doesn't support the face index is LaTeX, via PGF orDviFont (which just hard-codes index 0). I think the latter can be covered by the refactors in#29939

@QuLogic
Copy link
MemberAuthor

Also, tests use theWenQuanYi Zen Hei that we already conditionally use, but maybe we should generate a minimal.ttc file for testing instead.

@QuLogicQuLogic moved this fromReady for Review toWaiting for other PR inFont and text overhaulSep 3, 2025
@QuLogicQuLogic marked this pull request as draftSeptember 3, 2025 03:49
@QuLogicQuLogic linked an issueSep 26, 2025 that may beclosed by this pull request
@QuLogic
Copy link
MemberAuthor

I've rebased now that Ithink there should not be any other PRs that might cause conficts.

@QuLogicQuLogic marked this pull request as ready for reviewSeptember 26, 2025 04:47
@QuLogicQuLogicforce-pushed thettc-loading branch 2 times, most recently frome751dc2 toa32ad5bCompareOctober 23, 2025 08:33
@QuLogicQuLogicforce-pushed thettc-loading branch 2 times, most recently from44f03ea to1a2bba2CompareOctober 31, 2025 08:33
@QuLogic
Copy link
MemberAuthor

Just realized I didn't have any What's new docs here, so I've added a note.

Copy link
Member

@tacaswelltacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I have one minor quibble about c++ function signatures, not critical.

This enables loading a non-initial font from collections (`.ttc` files).Currently exposed for `FT2Font`, only.
This should allow listing the metadata from the whole collection, whichwill also pick the right one if specified, though it will not load thespecific index yet.
For backwards-compatibility, the path+index is passed around in alightweight subclass of `str`.
Note, this only has an effect if set as the global font. Otherwise, justthe font name is recorded, and the TeX engine's normal lookup isperformed.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees

No one assigned

Projects

Status: Ready for Review

Milestone

v3.11.0

Development

Successfully merging this pull request may close these issues.

Please add support for ttc font files (PDF/PS output)

2 participants

@QuLogic@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp