Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
FIX Update Axes limits from Axes.add_collection(... autolim=True)#30327
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| # sample data to give initial data limits | ||
| ax.plot([2,3,4], [0.4,0.6,0.5]) | ||
| np.testing.assert_allclose((ax.dataLim.xmin,ax.dataLim.xmax), (2,4)) | ||
| data_ymin,data_ymax=ax.dataLim.ymin,ax.dataLim.ymax | ||
| f,ax=plt.subplots() | ||
| # LineCollection with vertical lines spanning the Axes vertical, using transAxes | ||
| x= [1,2,3,4,5] | ||
| vertical_lines= [np.array([[xi,0], [xi,1]])forxiinx] | ||
| trans=mtransforms.blended_transform_factory(ax.transData,ax.transAxes) | ||
| ax.add_collection(LineCollection(line_segs,transform=trans)) | ||
| ax.autoscale_view(scalex=True,scaley=False) | ||
| np.testing.assert_allclose(ax.get_xlim(), [1.,4.]) | ||
| ax.add_collection(LineCollection(vertical_lines,transform=trans)) | ||
| # check that the x data limits are updated to include the LineCollection | ||
| np.testing.assert_allclose((ax.dataLim.xmin,ax.dataLim.xmax), (1,5)) | ||
| # check that the y data limits are not updated (because they are not transData) | ||
| np.testing.assert_allclose((ax.dataLim.ymin,ax.dataLim.ymax), (0.4,0.6)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Note 1: Before, the test did only check that the x data limits were expanded. It did not investigate the y data limits. Now it also ensures, that y data limits are not changed.
Note 2: I've switched from testing view limits to testing data limits, because that's the relevant quantity autolim influences. We save theautoscale_view() by not looking at the view limits.
Uh oh!
There was an error while loading.Please reload this page.
rcomer commentedJul 19, 2025
I should have looked at the CI before I looked at the code 🤦♀️ |
rcomer commentedJul 19, 2025
This breaks |
timhoffm commentedJul 20, 2025
Good point! We must update if either the transform or the offset transform use data coordinates. -> Fixed. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
... the update now happens separately for both directions, and only ifthat direction uses data coordinates. Previously, limits were alwaysrecalculated for both directions.Closesmatplotlib#30320.
55f7b10 intomatplotlib:mainUh oh!
There was an error while loading.Please reload this page.
…llection(... autolim=True)
….. autolim=True) (#30351)Co-authored-by: Thomas A Caswell <tcaswell@gmail.com>
... the update now happens separately for both directions, and only if that direction uses data coordinates. Previously, limits were always recalculated for both directions.
Closes#30320.